refactor: use yaml for oathkeeper rules #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krtk6160
force-pushed
the
refactor--yaml-oathkeeper-rules
branch
from
1b9d6b5 to
7b98454
Compare
charts/galoy/values.yaml
Outdated
| mutators: | ||
| - handler: id_token | ||
| config: | ||
| claims: '{"sub": "{{ print .Subject }}"}' |
There was a problem hiding this comment.
we were not passing the scope before?
Suggested change
| claims: '{"sub": "{{ print .Subject }}"}' | |
| claims: '{"sub": "{{ print .Subject }}", "scope": "{{ print .Extra.scope }}" }'`}' |
There was a problem hiding this comment.
We were not in the default values, but we override these in prod and there we were.
nicolasburtey
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.