feat(transform): destroy child entities when parent is destroyed

GameDevTecnico · Mar 3, 2025 · a0b8158 · a0b8158
1 parent a55164f
commit a0b8158
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 - Entity destruction detection to observers (#1458, **@kuukitenshi**).
-
+- Destroy child entities when parent entities are destroyed (#1418, **@kuukitenshi**).
 
 ## [v0.6.0] - 2025-02-10
 

diff --git a/core/src/ecs/command_buffer.cpp b/core/src/ecs/command_buffer.cpp
@@ -39,8 +39,8 @@ Entity CommandBuffer::create()
 void CommandBuffer::destroy(Entity entity)
 {
     std::lock_guard<std::mutex> lock(mMutex);
-
-    mCommands.emplace_back([entity](World& world) { world.destroy(entity); });
+    
+    mCommands.emplace_back([entity](World& world) { world.destroy(entity);});
 }
 
 std::unordered_map<std::string, Entity> CommandBuffer::spawn(const Blueprint& blueprint, bool withName)

diff --git a/engine/src/transform/plugin.cpp b/engine/src/transform/plugin.cpp
@@ -68,6 +68,15 @@ void cubos::engine::transformPlugin(Cubos& cubos)
         .without<LocalToParent>()
         .call(addComponent<LocalToParent>);
 
+    cubos.observer("destroy childs when parent is destroyed")
+        .onDestroy()
+        .call([](Query<Entity, const ChildOf&, Entity> query, Commands cmds) {
+            for (auto [entity, childOf, child] : query)
+            {
+                cmds.destroy(child);
+            }
+        });
+
     cubos.system("update LocalToParent's")
         .tagged(transformUpdateTag)
         .before(transformUpdatePropagateTag)