Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Menu Bar to Tesseratos #1235

Closed
wants to merge 8 commits into from
Closed

Add a Menu Bar to Tesseratos #1235

wants to merge 8 commits into from

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Jun 5, 2024 •
edited by jdbaracho
Loading

Description

Adds a menu bar plugin to Tesseratos. This plugin acts somewhat like the Toolbox plugin, except it interacts directly with the tools themselves.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@RiscadoA RiscadoA added this to the 0.3 Standalone Editor milestone Jun 5, 2024
@RiscadoA RiscadoA self-assigned this Jun 5, 2024
@RiscadoA RiscadoA linked an issue Jun 5, 2024 that may be closed by this pull request
Add a menu bar to Tesseratos which replaces the Toolbox #1234
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://GameDevTecnico.github.io/cubos/preview/pr-1235/

Built to branch gh-pages at 2025-01-31 00:07 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.27%. Comparing base (071ab63) to head (bcea446).
Report is 83 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   36.27%   36.27%           
=======================================
  Files         376      376           
  Lines       30851    30851           
=======================================
+ Hits        11191    11192    +1     
+ Misses      19660    19659    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 1234-add-a-menu-bar-to-tesseratos branch 2 times, most recently from 9756791 to 13a4bd3 Compare July 22, 2024 08:32
github-actions[bot]
github-actions bot previously requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@RiscadoA RiscadoA marked this pull request as ready for review July 22, 2024 08:34
@RiscadoA RiscadoA requested a review from a team as a code owner July 22, 2024 08:34
@RiscadoA RiscadoA force-pushed the 1234-add-a-menu-bar-to-tesseratos branch from 13a4bd3 to bcea446 Compare July 22, 2024 08:35
diogomsmiranda
diogomsmiranda approved these changes Jul 22, 2024
View reviewed changes
@RiscadoA RiscadoA marked this pull request as draft July 24, 2024 10:34
@RiscadoA RiscadoA modified the milestones: 0.3, 0.4 - ??? Aug 2, 2024
@RiscadoA RiscadoA removed this from the 0.4 milestone Sep 22, 2024
@RiscadoA RiscadoA added the S-Stale Has been abandoned, but kept for reference label Sep 22, 2024
@jdbaracho jdbaracho force-pushed the 1234-add-a-menu-bar-to-tesseratos branch from bcea446 to 1a168f8 Compare January 31, 2025 00:04
@github-actions github-actions bot added the P-Urgent This issue is a big priority, and it would be good to close it ASAP label Jan 31, 2025
@jdbaracho jdbaracho marked this pull request as ready for review January 31, 2025 09:03
@jdbaracho jdbaracho requested review from a team as code owners January 31, 2025 09:03
@jdbaracho jdbaracho requested review from jdbaracho, SrGesus and Dageus and removed request for a team January 31, 2025 09:03
@jdbaracho jdbaracho closed this Jan 31, 2025
@jdbaracho jdbaracho removed a link to an issue Jan 31, 2025
Add a menu bar to Tesseratos which replaces the Toolbox #1234
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogomsmiranda diogomsmiranda diogomsmiranda approved these changes

@Dacops Dacops Dacops approved these changes

@joaomanita joaomanita joaomanita approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@jdbaracho jdbaracho Awaiting requested review from jdbaracho jdbaracho was automatically assigned from GameDevTecnico/cubos-tools-team

@SrGesus SrGesus Awaiting requested review from SrGesus SrGesus was automatically assigned from GameDevTecnico/cubos-tools-team

@Dageus Dageus Awaiting requested review from Dageus Dageus was automatically assigned from GameDevTecnico/cubos-wildcard-team

Assignees

@RiscadoA RiscadoA

Labels
A-Tesseratos B-Tools P-Urgent This issue is a big priority, and it would be good to close it ASAP S-Stale Has been abandoned, but kept for reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RiscadoA @Dacops @joaomanita @diogomsmiranda @jdbaracho