Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Memory Leak #406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6057514
Memory Leak solved
malium Nov 30, 2019
303fc88
Another memory leak
malium Nov 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Source/Foundation/bsfUtility/Serialization/BsBinaryDiff.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,9 @@ namespace bs
bool isModified = curFieldData->size != otherTypeSize;
if (!isModified)
isModified = memcmp(curFieldData->value, buffer, otherTypeSize) != 0;


bs_stack_free(buffer);

return isModified;
}

Expand Down Expand Up @@ -598,6 +600,9 @@ namespace bs
if (!isModified)
isModified = memcmp(curBuffer, otherBuffer, otherTypeSize) != 0;

bs_stack_free(otherBuffer);
bs_stack_free(curBuffer);

return isModified;
}

Expand All @@ -614,6 +619,8 @@ namespace bs
if (!isModified)
isModified = memcmp(otherFieldData->value, buffer, curTypeSize) != 0;

bs_stack_free(buffer);

return isModified;
}

Expand Down