Request for Comment: New helper functions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only has `isInstanceOfAny` and `isInstanceOfNone` functions.
Currently only has `UniqueId.hasPermissionIn`.
Currently only has `BlockHitResult.blockStateBy` and `BlockHitResult.blockEntityBy`.
Merged
|
The location of these source files are what made sense to me at the time, these can be relocated and are not final, and a reason why this is behind an RFC and #4 should not be merged until this PR merges or not. There might be one final force-push onto #4 after the necessary changes to this proposal are done and merged, so that #4 only has the commits related to PC-1051's implementation. |
platform/fabric/src/main/kotlin/br/com/gamemods/minecity/fabric/helpers/WorldAccess.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Lobo Metalúrgico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing PC-1051 I noticed some easily extractable patterns from looking at the other existing implementations (only
FabricDoorPermissionat the time) and turned those into helper functions.Of note is
isInstanceOfAnyandisInstanceOfNone, which were used during the implementation of PC-1051 in order to simplify theobject !is A && object !is B && object !is C ...repetition.Another thing I found useful was extracting the conversion from
claim.hasPermission(player.identity().uuid(), permissionId)intoActionResults, since that code will get repeated with little to no changes in code for every single permission.The last set of helpers act on getting
Block|BlockStateinformation from aBlockHitResult, provided you have a world instance where that happens (which should be always).I hope these are as helpful to you as it were to us while developing PC-1051.
An example for using this new API can be found on: #4, which is where they origined from.