Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cookie clicker channel #35

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

satasatalight
Copy link
Contributor

@satasatalight satasatalight commented Jan 23, 2024

Description

Cookie-Clicker-Screen.mp4

Adds a cookie clicker themed donation screen!
Donations click the cookie, auto-buy the most expensive building available, and scroll to it's building / store window. The news ticker at the top runs GDQ-themed parodies of the actual cookie clicker news ticker.

I wanted to include more features in the channel but I didn't want to go overboard with a tiny donation screen. Also, just generally sorry about anything that I messed up. This is the first time I've ever made my code public before and this project made me learn a lot of new things so I was kind of winging it with the entire project.

Checklist:

  • My channel contains no first-party Nintendo assets.
  • I understand that GamesDoneQuick may reject, make changes to, or choose not to show this channel on broadcast, and that discussion or merging does not guarantee the work will be used.

@chrishanel
Copy link
Member

I am playing cookie clicker for the first time in ages because of this PR and all i have to say is this is your fault

@chrishanel
Copy link
Member

Okay, I have spoken with Orteil, one of the Cookie Clicker devs, who has given his blessing to this channel being used on the broadcast. Will think about the design aspect over the next couple days but overall this is promising :D

@chrishanel
Copy link
Member

you did this
image

@satasatalight
Copy link
Contributor Author

Hey! This PR I made a year ago was my first time writing in React and TypeScript, which led to some very unorganized / inconsistent code in the original commit. I get that my PR was never formally closed but I can understand if the reviewers took me out of consideration after trying to read any of it. I tried to rewrite and address a lot of these issues in these new commits; I would really appreciate if you could reconsider my submission! Let me know if I need to change anything 🫡

satasatalight and others added 7 commits January 9, 2025 15:47
included more react.js native solutions. replaced alotta raw javascript
On Windows, the scrollbars take up fixed size and have very clear
Windows stylings, which doesn't match the preview video on the PR which
shows overlay scrollbars. Since scrolling is ran programmatically anyway,
I've hidden the scrollbar.
@VodBox VodBox merged commit 5a69b70 into GamesDoneQuick:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants