Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis #178

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Emojis #178

wants to merge 17 commits into from

Conversation

DilemmaGX
Copy link
Contributor

Get and parse emojis.

Also included some new and fancy stuff (Animated PNG Icons).

Still experimenting with tooltips (title), but not implemented in this version.

Reference(s):

Fragment Related Source
emoji json https://unpkg.com/@angelofana/[email protected]/emoji-array.json
grinning cat (3D) https://github.com/microsoft/fluentui-emoji
animated grinning cat (3D) https://github.com/Tarikul-Islam-Anik/Animated-Fluent-Emojis

DilemmaGX and others added 8 commits February 2, 2024 15:37
Added `internationalDefault`

Co-Authored-By: fath11 <[email protected]>
compatibility with v8 ++
(some browsers cannot read gandi "string" type properly, so I added a fixture)
@DilemmaGX
Copy link
Contributor Author

DilemmaGX commented Feb 5, 2024

image

image

QQ202426-6420-HD.mp4

Felt sleepy editing the final version, so their might be something buggy that I didn't knotice. Please acknowledge me if there's any 🐞bug.

@fath11
Copy link
Contributor

fath11 commented Feb 6, 2024

Oh god...

I would recommend you use this package: https://www.npmjs.com/package/emoji-dictionary
Also, I don't know the point of get all data block as it is VERY laggy on my computer.

@DilemmaGX
Copy link
Contributor Author

Oh god...

I would recommend you use this package: https://www.npmjs.com/package/emoji-dictionary Also, I don't know the point of get all data block as it is VERY laggy on my computer.

Thanks for your advice. the get all data block is opened to users to recreate some of their own emoji functions and data type.

About lag issues: Well, II believed that the lag caused by get all data is mainly due to Gandi's scratch-gui, when trying to draw tremendous amount of text inside the reporter return box (or the variable monitors). In real projects, programmers were expected to create programmes using data returned by get all data instead of directly monitoring it. In my test, avoiding directly rendering the return value on screen (eg: use it with Not.js or other json processors) will not cause lags

@DilemmaGX DilemmaGX marked this pull request as draft February 27, 2024 10:24
@DilemmaGX DilemmaGX marked this pull request as ready for review May 11, 2024 11:43
@DilemmaGX
Copy link
Contributor Author

Used unpkg as data source (instead of embeding inside the project)

Copy link
Contributor

@sylarhcn sylarhcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 封面过大,请不要将过大的文件数据 base64 到扩展实现文件中,封面仅用于目录展示,你可以使用 module 分隔
  2. 封面尺寸和大小有标准,请参看 readme 中的 asset 标准,理论上封面越小越好,可以加快目录的展示速度
  3. 单个文件过大,在 github 网页 pr 的 file changed 中 ,无法展示 diff,reviewer 无法查看。

@DilemmaGX
Copy link
Contributor Author

Mark as on hold. Will be reworking after a couple of time.

@DilemmaGX DilemmaGX marked this pull request as draft July 23, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants