Merge pull request #24 from GannettDigital/performance

Set all auto-generated resolve functions to resolve serially
GannettDigital · Mar 6, 2020 · 603a4cc · 603a4cc
2 parents 0313f10 + b191506
commit 603a4cc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/go.mod b/go.mod
@@ -1,5 +1,5 @@
 module github.com/GannettDigital/graphql-gen
 
-require github.com/GannettDigital/graphql v0.0.0-20180502221234-69afe7345de2
+require github.com/GannettDigital/graphql v0.8.2
 
 go 1.13
diff --git a/go.sum b/go.sum
@@ -1,2 +1,2 @@
-github.com/GannettDigital/graphql v0.0.0-20180502221234-69afe7345de2 h1:UX3UiSWtirltOWcEf6GiXpY3yhosQHRzUjuXqeumeZc=
-github.com/GannettDigital/graphql v0.0.0-20180502221234-69afe7345de2/go.mod h1:lbqlJ35xvVRSsEjEXGH96xlGDuy63f0MCYu86JTd96c=
+github.com/GannettDigital/graphql v0.8.2 h1:9ozB5DieYfwN7AOnUSybgONQS8s2L8LyN/xT5Tvm7y4=
+github.com/GannettDigital/graphql v0.8.2/go.mod h1:/pBTUuGF3BiEuSQor7AUwe2u8BrFQx+m/EIvNpu2R94=
diff --git a/gql/builder.go b/gql/builder.go
@@ -273,9 +273,10 @@ func (ob *ObjectBuilder) buildFields(sType reflect.Type, parent string, baseFiel
 		name := fieldName(field)
 		description := field.Tag.Get("description")
 		f := &graphql.Field{
-			Name:    name,
-			Type:    gtype,
-			Resolve: ResolveByField(name, parent),
+			Name:          name,
+			Type:          gtype,
+			Resolve:       ResolveByField(name, parent),
+			ResolveSerial: true, // autogenerated fields don't require any network activity so always resolve serially
 		}
 
 		if strings.HasPrefix(description, deprecationPrefix) {