Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add teamware privacy policy variables #3

Merged
merged 8 commits into from
Mar 10, 2023
Merged

Conversation

davidwilby
Copy link

Just making an attempt at adding these, but don't really know what I'm doing I'm afraid.

Relates to GateNLP/gate-teamware#298

@davidwilby davidwilby requested a review from ianroberts March 2, 2023 14:42
@davidwilby davidwilby force-pushed the teamware_privacy_policy branch from 3ade90a to e56e949 Compare March 2, 2023 14:51
@davidwilby davidwilby force-pushed the teamware_privacy_policy branch from e56e949 to ea3fbe7 Compare March 2, 2023 14:52
…sponding env var completely unset rather than explicitly setting it to an empty string value.
Copy link
Member

@ianroberts ianroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cleaned up the template a little with my own commits, and left a couple of comments with specific questions.

Recommend we don't actually merge this PR until the teamware PR is finished, as there will be more changes to make if we want to support bind-mounting a custom policy.

gate-teamware/README.md Outdated Show resolved Hide resolved
@ianroberts
Copy link
Member

I've made the change to default admin options to match host ones, but there may be an argument for making this happen in the teamware code rather than just in the chart.

@davidwilby
Copy link
Author

I've made the change to default admin options to match host ones, but there may be an argument for making this happen in the teamware code rather than just in the chart.

This is now done in the teamware backend as well d59aae1

@ianroberts ianroberts force-pushed the teamware_privacy_policy branch from 43fe15a to b5d7b48 Compare March 10, 2023 14:01
@ianroberts
Copy link
Member

I've added an option to mount custom policies via a ConfigMap volume. I think this is ready to go now - if I merge this now the policies stuff won't do anything by default as the chart will still deploy the latest release (which doesn't know anything about policies), but I'll merge it anyway as you can override the image tags when installing, and I'll do another PR with the version bump once a compatible image is released.

@ianroberts ianroberts merged commit 7420071 into main Mar 10, 2023
@ianroberts ianroberts deleted the teamware_privacy_policy branch March 10, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants