Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a hidden private field access error in update installation #165

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

Gawdl3y
Copy link
Owner

@Gawdl3y Gawdl3y commented Feb 29, 2024

The Proxy wrapping that the Vue ref does on the update object results in an incorrect error about private field access coming from Tauri code due to TypeScript's private field checking. Storing the update object in a standard variable instead of a ref avoids this.

@Gawdl3y Gawdl3y added the bug Something isn't working label Feb 29, 2024
@Gawdl3y Gawdl3y merged commit 84f52a8 into main Feb 29, 2024
6 checks passed
@Gawdl3y Gawdl3y deleted the fix/updater-install-private-field branch February 29, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant