Polymorphic classes #895
Open
Polymorphic classes #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove private accessors - use Injector in constructor - split code into smaller functions - fill docs
Gbuomprisco
reviewed
Aug 29, 2019
|
|
||
| /** | ||
| * @name onBlur | ||
| */ | ||
| @Output() public onBlur: EventEmitter<any> = new EventEmitter(); | ||
| @Output() public onBlur: EventEmitter<FocusEvent> = new EventEmitter(); |
There was a problem hiding this comment.
I may have not used these in order to avoid errors with angular universal 🤔 @DanielKucal thoughts?
There was a problem hiding this comment.
I think things like those should be polyfilled in the server environment rather than in every project separately, e.g. like here: https://github.com/Angular-RU/angular-universal-starter/blob/master/server.ts#L11
We can eventually add quick polyfills like in tag-input.ts:
const DragEvent = (window as any).DragEvent;
@Gbuomprisco, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goal of this change is to allow developers to easily extend the functionality of
ngx-chipsclasses. To achieve it introduces the following things:Injectorto the constructor, instead of standalone dependenciesonTab()to handle keys events directly