Default to bonus city for refining #84
Conversation
| return itemName.includes(keyword); | ||
| }); | ||
| } | ||
| const hasProductionBonus = getDoesItemHaveProductionBonusForCity(city === 'Caerleon' ? itemName : parentItem, city); |
There was a problem hiding this comment.
I replicated the logic around Caerleon here but I'm not sure I understand it. What needs to be done in mutations.ts to replicate it for setting the default city correctly on currentItem change?
There was a problem hiding this comment.
Idk, it's probably some kind of legacy code. Everything should works anyway with parentItem and itemName. I would prefer to leave itemName here so that we don't actually depend on the parent element.
There was a problem hiding this comment.
If you disable the "multiple cities" setting, each city should be changed to the value of the "sell items" city/"main city" (the very first in the list). The exception is the Black market. If the "sell items" city is the black market, then all the others must be Caerleon when you disable "multiple cities"
Nfinished
force-pushed
the
default-to-bonus-city
branch
from
e59a29c to
2b8e74f
Compare
| export const MARKET_SELL_ORDER_FEE = MARKET_ORDER_FEE + MARKET_SETUP_FEE; | ||
| export const PRODUCTION_BONUS_BY_CITY = { |
There was a problem hiding this comment.
It doesn't look like its place is in constants. It would probably be better in a separate .json file
| if (hasProductionBonus) { | ||
| return useFocus ? 53.9 : 36.7; | ||
| } else { | ||
| return useFocus ? 43.5 : 15.2;; |
There was a problem hiding this comment.
| return useFocus ? 43.5 : 15.2;; | |
| return useFocus ? 43.5 : 15.2; |
|
Meanwhile, PR looks good, I'll take a better look after the New Year |
Adds a couple utils for determining production bonuses, and defaults to production bonus city when refining. I was a little confused by the logic in profit-tree so I didn't give it the same default treatment, I've left a comment on the bit I found confusing.
It looks like the linter also created some whitespace changes so I'd recommend hiding those when reviewing