Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IridiumSkyblock & UltimateClaims support #77

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Added IridiumSkyblock & UltimateClaims support #77

merged 4 commits into from
Aug 9, 2024

Conversation

Khontrom
Copy link
Contributor

@Khontrom Khontrom commented Aug 3, 2024 •
edited
Loading

Added IridiumSkyblock & UltimateClaims support

@Khontrom
Copy link
Contributor Author

Khontrom commented Aug 4, 2024

Added UltimateClaims Support

@Khontrom Khontrom changed the title Added IridiumSkyblock support Added IridiumSkyblock & UltimateClaims support Aug 4, 2024
@poyrazinan poyrazinan self-requested a review August 7, 2024 18:28
@poyrazinan poyrazinan added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 7, 2024
@poyrazinan poyrazinan added this to the b107 milestone Aug 7, 2024
poyrazinan
poyrazinan requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@poyrazinan poyrazinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Needed documentation on IridiumListener
  • Needed documentation on UltimateListener

All the other things seems ok, thank you for adding 2 more plugin hook to Farmer!
Waiting your update :)

@poyrazinan poyrazinan removed their assignment Aug 7, 2024
@poyrazinan poyrazinan added the help wanted Extra attention is needed label Aug 7, 2024
poyrazinan
poyrazinan approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@poyrazinan poyrazinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@poyrazinan poyrazinan merged commit 6e77407 into Geik-xyz:main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyrazinan poyrazinan poyrazinan approved these changes

Assignees

@Khontrom Khontrom

Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
b107
Development

Successfully merging this pull request may close these issues.
2 participants
@Khontrom @poyrazinan