Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make slit illum interactive #330

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
9d51871
The first iteration of adding interactivity to the makeSlitIllum prim…
Jan 4, 2022
5a305c8
The first attempt of separating regions from fitting. Created a custo…
Jan 13, 2022
a319f1b
bin editing works
Jan 14, 2022
65a4542
bin editing works
Jan 14, 2022
8e0b19c
Bin editor correctly accepts parsed user bins
Jan 24, 2022
8663ff3
Both interactive bin editor and bin fitter work with data correctly
Jan 24, 2022
855f6d2
Enable masking in bin fitting
Jan 25, 2022
592ffd4
Added interactive interface for last step 1d fitting, section param a…
Feb 7, 2022
dbd126a
Merge branch 'master' into feature/makeSlitIllum_interactive
Feb 7, 2022
9779ab3
Cleaned up the makeSlitIllum code
Feb 23, 2022
b6c4b0d
Removed some comments and optimized some code
Feb 24, 2022
21f9c0a
Merge branch 'master' into feature/makeSlitIllum_interactive
Feb 24, 2022
20a3588
Fix PrimitiveVisualizer to accept ui_params=None
Feb 24, 2022
9d49249
Fix BinResettingUI due to loss of dependency
Feb 24, 2022
cc063fb
remove cyclip.c from git
chris-simpson Feb 24, 2022
b501e3c
fixed lingering tic marks when reducing number of bins, added padding…
Feb 24, 2022
8d71ab9
made path to set y_range so that it will respect updates, using for m…
Feb 25, 2022
9ac50ff
Interpolation etc
Mar 8, 2022
1e7506d
Removed interactive interface for the interpolation step; added bound…
Mar 23, 2022
02915f4
Modified tests for makeSlitIllum and updated ref file
Mar 23, 2022
8a27aaf
Merge branch 'master' into feature/makeSlitIllum_interactive
Mar 24, 2022
f1f43ec
Added Jinja2==3.0.3 to conda_deps in tox.ini
Mar 24, 2022
3bfce0d
Removed an accidental comment
Mar 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PrimitiveVisualizer to accept ui_params=None
Olesja Smirnova committed Feb 24, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 20a3588da0eccee8e9d022248e459e8b28b446c9
2 changes: 1 addition & 1 deletion geminidr/interactive/interactive.py
Original file line number Diff line number Diff line change
@@ -153,7 +153,7 @@ def __init__(self, title='', primitive_name='',
# Text widget for triggering ok/cancel via DOM text change event
self._ok_cancel_holder = None

self._reinit_params = {k: v for k, v in ui_params.values.items()}
self._reinit_params = {k: v for k, v in ui_params.values.items()} if ui_params else {}

self.fits = []