Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17_getBetaMix_dbetaMix #23

Merged
merged 29 commits into from
Nov 27, 2023
Merged

17_getBetaMix_dbetaMix #23

merged 29 commits into from
Nov 27, 2023

Conversation

audreyyeoCH
Copy link
Collaborator

Within dbetabinom.R, refactor getBetaMix and dbetaMix

@audreyyeoCH audreyyeoCH changed the title 17_getBetaMix 17_getBetaMix_dbetaMix Nov 6, 2023
@audreyyeoCH
Copy link
Collaborator Author

Draft PR only

@audreyyeoCH audreyyeoCH marked this pull request as ready for review November 14, 2023 08:18
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive, ready for your review, thanks a lot!

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @audreyyeoCH , let's have a look in the standup together at the error

R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
examples/postprob.R Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Nov 16, 2023

Hi @danielinteractive , we did example files for this right ? I see it's only got dbinom... 😩

I would just like to check it out before i remove the @note on

#' @note `q` can be a vector.

but i think the helper function can be reviewed while I fix some errors on the introduction file.

the #TODO or TODO comments should no longer be there, thanks!

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , please see below

R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
audreyyeoCH and others added 6 commits November 16, 2023 14:50
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]>
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Outdated Show resolved Hide resolved
R/dbetabinom.R Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
tests/testthat/test-dbetabinom.R Outdated Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive could you review the changes and also I'm stuck here :

dbetaMix(

There is a warning In weights * dbeta(x, par[, 1], par[, 2]) : longer object length is not a multiple of shorter object length

R/dbetabinom.R Outdated Show resolved Hide resolved
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH audreyyeoCH merged commit 6af999c into main Nov 27, 2023
3 checks passed
@audreyyeoCH audreyyeoCH deleted the 17_getBetaMix branch November 27, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants