Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24_predprob.R #25

Merged
merged 13 commits into from
Nov 30, 2023
Merged

24_predprob.R #25

merged 13 commits into from
Nov 30, 2023

Conversation

audreyyeoCH
Copy link
Collaborator

@audreyyeoCH audreyyeoCH commented Nov 29, 2023 •
edited by danielinteractive
Loading

closes #24

danielinteractive
danielinteractive reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audreyyeoCH , please see below

R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Show resolved Hide resolved
R/predprob.R Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Nov 30, 2023 •
edited
Loading

Thanks Daniel!

  • removed all defaults, this is now is my personal checklist
  • py is density

danielinteractive
danielinteractive reviewed Nov 30, 2023
View reviewed changes
R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
R/predprob.R Outdated Show resolved Hide resolved
audreyyeoCH and others added 2 commits November 30, 2023 13:01
@audreyyeoCH @danielinteractive
Update R/predprob.R
df98958 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@audreyyeoCH @danielinteractive
Update R/predprob.R
e5f9053 
Co-authored-by: Daniel Sabanes Bove <[email protected]>
@danielinteractive danielinteractive marked this pull request as ready for review November 30, 2023 14:32
@audreyyeoCH audreyyeoCH merged commit 06ae0a2 into main Nov 30, 2023
3 checks passed
@audreyyeoCH audreyyeoCH deleted the 24_predprob.R branch November 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean predprob.R
2 participants
@audreyyeoCH @danielinteractive