Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #78

Merged
merged 6 commits into from
Dec 1, 2024
Merged

dev #78

Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pack as content and copy to output
WeihanLi committed Nov 29, 2024
commit f32b84ad7e5e71411fec7e087a4a16f9efb5d36e
17 changes: 3 additions & 14 deletions src/c#/GeneralUpdate.Bowl/GeneralUpdate.Bowl.csproj
Original file line number Diff line number Diff line change
@@ -24,18 +24,6 @@
<Pack>True</Pack>
<PackagePath></PackagePath>
</None>
<None Update="Applications\Linux\procdump-3.3.0-0.cm2.x86_64.rpm">
<Pack>True</Pack>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Applications\Linux\procdump-3.3.0-0.el8.x86_64.rpm">
<Pack>True</Pack>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Applications\Linux\procdump_3.3.0_amd64.deb">
<Pack>True</Pack>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>

<ItemGroup>
@@ -47,8 +35,9 @@
</ItemGroup>

<ItemGroup>
<EmbeddedResource Include="Applications\**\*">
<Content Include="Applications\**\*">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</EmbeddedResource>
<PackageCopyToOutput>true</PackageCopyToOutput>
</Content>
</ItemGroup>
</Project>

Unchanged files with check annotations Beta

/// <summary>
/// Recursively read all files in the folder path.
/// </summary>
private IEnumerable<FileNode> ReadFileNode(string path, string rootPath = null)

Check warning on line 241 in src/c#/GeneralUpdate.Common/FileBasic/StorageManager.cs

GitHub Actions / build

Cannot convert null literal to non-nullable reference type.
{
var resultFiles = new List<FileNode>();
rootPath ??= path;
{
{ "RecordId", recordId },
{ "Status", status },
{ "Type", type }

Check warning on line 37 in src/c#/GeneralUpdate.Common/Shared/Service/VersionService.cs

GitHub Actions / build

Possible null reference argument for parameter 'value' in 'void Dictionary<string, object>.Add(string key, object value)'.
};
await PostTaskAsync<BaseResponseDTO<bool>>(httpUrl, parameters, ReportRespJsonContext.Default.BaseResponseDTOBoolean);
}
public class CompressProvider
{
private static ICompressionStrategy _compressionStrategy;

Check warning on line 9 in src/c#/GeneralUpdate.Common/Compress/CompressProvider.cs

GitHub Actions / build

Non-nullable field '_compressionStrategy' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
private CompressProvider() { }
try
{
var path = Path.Combine(_manager.Path, $"{_version?.Name}{_manager.Format}");
await DownloadFileRangeAsync(_version.Url, path);

Check warning on line 40 in src/c#/GeneralUpdate.Common/Download/DownloadTask.cs

GitHub Actions / build

Dereference of a possibly null reference.

Check warning on line 40 in src/c#/GeneralUpdate.Common/Download/DownloadTask.cs

GitHub Actions / build

Possible null reference argument for parameter 'url' in 'Task DownloadTask.DownloadFileRangeAsync(string url, string path)'.
}
catch (Exception exception)
{
Debug.WriteLine(exception.Message);
_manager.OnMultiDownloadError(this, new MultiDownloadErrorEventArgs(exception, _version));

Check warning on line 45 in src/c#/GeneralUpdate.Common/Download/DownloadTask.cs

GitHub Actions / build

Possible null reference argument for parameter 'version' in 'MultiDownloadErrorEventArgs.MultiDownloadErrorEventArgs(Exception exception, object version)'.
}
}
#region Private Members
private readonly ImmutableList<DownloadTask>.Builder _downloadTasksBuilder = ImmutableList.Create<DownloadTask>().ToBuilder();
private ImmutableList<DownloadTask> _downloadTasks;

Check warning on line 15 in src/c#/GeneralUpdate.Common/Download/DownloadManager.cs

GitHub Actions / build

Non-nullable field '_downloadTasks' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
#endregion Private Members
private ImmutableList<DownloadTask> DownloadTasks => _downloadTasks ?? _downloadTasksBuilder.ToImmutable();
public event EventHandler<MultiAllDownloadCompletedEventArgs> MultiAllDownloadCompleted;

Check warning on line 31 in src/c#/GeneralUpdate.Common/Download/DownloadManager.cs

GitHub Actions / build

Non-nullable event 'MultiAllDownloadCompleted' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the event as nullable.
public event EventHandler<MultiDownloadCompletedEventArgs> MultiDownloadCompleted;

Check warning on line 32 in src/c#/GeneralUpdate.Common/Download/DownloadManager.cs

GitHub Actions / build

Non-nullable event 'MultiDownloadCompleted' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the event as nullable.
public event EventHandler<MultiDownloadErrorEventArgs> MultiDownloadError;

Check warning on line 33 in src/c#/GeneralUpdate.Common/Download/DownloadManager.cs

GitHub Actions / build

Non-nullable event 'MultiDownloadError' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the event as nullable.
public event EventHandler<MultiDownloadStatisticsEventArgs> MultiDownloadStatistics;
#endregion Public Properties