Merge pull request #107 from GeneralMagicio/fix/match-pending-donation

Fixed issue in matching pending donation
GeneralMagicio · Oct 23, 2024 · 333c2db · 333c2db
2 parents db85966 + 5b0f6c1
commit 333c2db
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/repositories/projectRoundRecordRepository.ts b/src/repositories/projectRoundRecordRepository.ts
@@ -18,6 +18,9 @@ export async function updateOrCreateProjectRoundRecord(
   qfRoundId?: number | null,
   earlyAccessRoundId?: number | null,
 ): Promise<ProjectRoundRecord> {
+  if (!qfRoundId && !earlyAccessRoundId) {
+    throw new Error('No round specified on updateOrCreateProjectRoundRecord');
+  }
   try {
     let query = Donation.createQueryBuilder('donation')
       .select('SUM(COALESCE(donation.amount))', 'totalDonationAmount')

diff --git a/src/resolvers/donationResolver.ts b/src/resolvers/donationResolver.ts
@@ -897,6 +897,10 @@ export class DonationResolver {
           activeQfRoundForProject.isEligibleNetwork(networkId)
         ) {
           donation.qfRound = activeQfRoundForProject;
+        } else {
+          throw new Error(
+            i18n.__(translationErrorMessagesKeys.ROUND_NOT_FOUND),
+          );
         }
         if (draftDonationEnabled && draftDonationId) {
           const draftDonation = await DraftDonation.findOne({