check allocation based on all projects #387
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lovelgeorge99
requested review from
ae2079 and
aminlatifi
and removed request for
ae2079
There was a problem hiding this comment.
@lovelgeorge99 please coordinate with @bens-magic about the policy you have chosen, checking projects one by one to be sure the round is done
src/services/tokenPrice.service.ts
Outdated
| const results = []; | ||
| for (const project of allProjects) { | ||
| const result = await getTokenPriceRangeStatus({ allRounds, project }); | ||
| results.push(result.isPriceUpToDate); |
There was a problem hiding this comment.
You can exit by seeing the first false.
| const { data: allRounds } = useFetchAllRound(); | ||
| const [isAllocationDone, setIsAllocationDone] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const cheakAllProjectStatus = async () => { | ||
| if (allProjects && allRounds) { | ||
| const allProjectsReady = await checkAllProjectsStatus( | ||
| allProjects?.projects, | ||
| allRounds, | ||
| ); | ||
| setIsAllocationDone(allProjectsReady); | ||
| } | ||
| }; | ||
|
|
||
| cheakAllProjectStatus(); | ||
| }, [allProjects, allRounds]); |
There was a problem hiding this comment.
It's not efficient, it will load per project card. We can calculate it once in the useFetchAllRound
There was a problem hiding this comment.
the useFetchAllRound only provides if the isBatchMintingExecuted or not ..we also need to check if the price of the tokens is up to date for the each project which is done here src/services/tokenPrice.ts/getTokenPriceRangeStatus that is why i used this
There was a problem hiding this comment.
We may find another place. The point is that logic is repeated twice in code, and in one of them (if I am not mistaken) will be executed in each card!
It's better move it to a hook with useQuery and cache it!
…o check-allocation-projects
| ) => { | ||
| return useQuery({ | ||
| enabled: !!allProjects && !!allRounds, | ||
| queryKey: ['projectPriceStatus', allProjects, allRounds], |
There was a problem hiding this comment.
allProjects and allRounds types are not of string type, right? If so, having them in the cache key is inefficient! It will cause the query to re-execute again and again.
Maybe the projectPriceStatus is enough since all the projects and all the rounds would not change.
| const [isAllocationDone, setIsAllocationDone] = useState(false); | ||
|
|
||
| const { data: projectPriceUpdated } = useCheckProjectPriceStatus( | ||
| allProjects, | ||
| allRounds, | ||
| ); | ||
|
|
||
| useEffect(() => { | ||
| console.log('IsAllocation Done', projectPriceUpdated); | ||
| setIsAllocationDone(!!projectPriceUpdated); | ||
| }, [projectPriceUpdated]); |
There was a problem hiding this comment.
I think that useEffect doesn't improve efficiency. As I know, the component will rerender already due to projectPriceUpdated update.
| const [isAllocationDone, setIsAllocationDone] = useState(false); | |
| const { data: projectPriceUpdated } = useCheckProjectPriceStatus( | |
| allProjects, | |
| allRounds, | |
| ); | |
| useEffect(() => { | |
| console.log('IsAllocation Done', projectPriceUpdated); | |
| setIsAllocationDone(!!projectPriceUpdated); | |
| }, [projectPriceUpdated]); | |
| const { data: projectPriceUpdated } = useCheckProjectPriceStatus( | |
| allProjects, | |
| allRounds, | |
| ); | |
| const isAllocationDone = !!projectPriceUpdated; |
There was a problem hiding this comment.
ok thank you @aminlatifi ...really helpful
| const [isAllocationDone, setIsAllocationDone] = useState(false); | ||
|
|
||
| const { data: projectPriceUpdated } = useCheckProjectPriceStatus( | ||
| allProjects, | ||
| allRounds, | ||
| ); | ||
|
|
||
| useEffect(() => { | ||
| setIsAllocationDone(!!projectPriceUpdated); | ||
| }, [projectPriceUpdated]); |
No description provided.