Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a puts from Pipedrive::Base #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed a puts from Pipedrive::Base #27

wants to merge 1 commit into from

Conversation

neckhair
Copy link

This caused some unnecesary output in logs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.34%) to 78.45% when pulling 58933a7 on neckhair:neckhair-patch-remove-puts into e640075 on GeneralScripting:master.

@ericboehs
Copy link

The puts is mucking up my test output. Ick. Can we get this fast tracked please? cc: @jufemaiz @jeanmartin

As an Rspec work around (until his is merged):

# Pipedrive is putsing bad_request information. Silence that until resolved.
# See https://github.com/GeneralScripting/pipedrive-ruby/pull/27 
before { allow(Pipedrive::Base).to receive(:puts) }

@jufemaiz
Copy link
Contributor

@ericboehs + @neckhair I'm not actually able to do anything on this repo :(

@jufemaiz
Copy link
Contributor

Ping @jwaterfaucett @RobRoy

@jufemaiz
Copy link
Contributor

@GeneralScripting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants