Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboards Table + Scores Table #10

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Leaderboards Table + Scores Table #10

merged 2 commits into from
Feb 2, 2024

Conversation

adammotts
Copy link
Collaborator

Description

Link to Ticket

Please include a summary of the changes and the related issue. Please also include relevant motivation, context, and images! If its a frontend ticket, screenshots are important, if its a backend ticket, please add pictures of relevant postman screenshots or console printouts.

Added leaderboards table and scores bridge table

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit tests, provide the file name the tests are in. If they are not unit tests, describe how you tested the change.

I didn't

Checklist

  • [1] I have performed a self-review of my code
  • [0] I have reached out to another developer to review my code
  • [1] I have commented my code, particularly in hard-to-understand areas
  • [?] New and existing unit tests pass locally with my changes

Copy link
Contributor

@leoRysing leoRysing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a bit of cleanup syntax wise before it gets merged

backend/src/db/migrations/init.sql Outdated Show resolved Hide resolved
backend/src/db/migrations/init.sql Outdated Show resolved Hide resolved
@adammotts adammotts requested a review from leoRysing February 1, 2024 20:57
Copy link
Contributor

@leoRysing leoRysing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! LGTM

@leoRysing leoRysing merged commit ab3ac35 into main Feb 2, 2024
3 checks passed
@leoRysing leoRysing deleted the adam-leaderboard branch February 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants