NOT YET #22
Merged
NOT YET #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be good, but still waiting to add the get all posts from followings once cam's branch is done |
leoRysing
reviewed
Feb 26, 2024
| @@ -31,6 +31,7 @@ func main() { | |||
|
|
|||
| routes.SetupUserRoutes(r, db) | |||
| routes.SetupETradeRoutes(r, db) | |||
| routes.SetupPostRoutes(r, db) | |||
There was a problem hiding this comment.
going to add a change on Cam's branch to. move all of these to helper fyi
leoRysing
reviewed
Feb 26, 2024
| DROP TABLE IF EXISTS posts; | ||
|
|
||
| --Create post type table | ||
| CREATE TYPE post_type_enum AS ENUM ( |
There was a problem hiding this comment.
For enum can we do Caps / underscore case? IE '1_MONTH_SUM'
Also comment is the stock performance comment right?
| post_type post_type_enum NOT NULL, | ||
| num_data FLOAT NOT NULL, | ||
| ticker_symbol VARCHAR(9), | ||
| time_stamp TIMESTAMP DEFAULT CURRENT_TIMESTAMP, |
There was a problem hiding this comment.
I think the gorm / sql format for this would be created_at? everything else is good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change below here
[Link to Ticket](insert the link to your ticket inside the parenthesis here)
Please include a summary of the changes and the related issue. Please also include relevant motivation, context, and images! If its a frontend ticket, screenshots are important, if its a backend ticket, please add pictures of relevant postman screenshots or console printouts.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. If they are unit tests, provide the file name the tests are in. If they are not unit tests, describe how you tested the change.
Change below here. If this is a frontend MR, include screenshots
Add here
Checklist