Backend Copy Portfolio Routes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoRysing
force-pushed
the
nj-be-copy
branch
2 times, most recently
from
d021bbe to
19d02bc
Compare
| } | ||
|
|
||
| // CopyPortfolio copies the positions from the target portfolio into the current user's portfolio. | ||
| func (os *PortfolioService) CopyPortfolio(currentUserPortfolio models.UserPortfolio, targetPortfolio models.UserPortfolio) (models.UserPortfolio, error) { |
There was a problem hiding this comment.
Are we copying the portfolio to the e-trade account?
There was a problem hiding this comment.
this just has routes to copy portfolios in our own db for now. ETrade endpoints are not working so I'm looking into fixing that + how to make trade orders for securities with the api
backend/src/services/etrade.go
Outdated
| @@ -18,8 +17,10 @@ const APIEnv = "apisb" // "apisb" = SANDBOX, "api" = PROD | |||
|
|
|||
| var oauthClient = oauth.Client{ | |||
| Credentials: oauth.Credentials{ | |||
| Token: os.Getenv("OAUTH_KEY"), | |||
| Secret: os.Getenv("OAUTH_SECRET"), | |||
| // Token: os.Getenv("OAUTH_KEY"), | |||
There was a problem hiding this comment.
What's the reasoning for removing this?
There was a problem hiding this comment.
forgot to change that, will fix later tn
leoRysing
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds routes for copying a portfolio.
Adds dummy data for portfolios and positions.
Adds separate GetPortfolio Route for convenience.
How Has This Been Tested?
copy route updates data in db
Checklist