Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature generic card and popup modal #20

Merged
merged 9 commits into from
Feb 1, 2024

Conversation

CaitlinFlynn
Copy link
Contributor

Description

Link to Ticket

Created a clickable card and popup modal component that currently shows medication data. Created using react native paper so tailwind can not be used for styling.

How Has This Been Tested?

Tested visually

Checklist

  • [ ✅] I have performed a self-review of my code
  • [ ✅] I have reached out to another developer to review my code
  • [ ✅] I have commented my code, particularly in hard-to-understand areas
  • [ ✅] New and existing unit tests pass locally with my changes

@MattCMcCoy
Copy link
Contributor

MattCMcCoy commented Jan 31, 2024

hey are you able to resolve the merge conflicts? :)
make sure all of yalls stuff is in components folder everything in main rn should take priority.
lmk if you need help

@AdharshKan42
Copy link
Contributor

I figured there was going to be a merge conflict, we can resolve that and update the branch. Does it matter if our commits are kinda jank (aka should we clean them up) or does it not really matter?

@MattCMcCoy
Copy link
Contributor

Nah, theres a squash and merge option which when it gets merged into main it will merge all of the commits into a single commit. Ill let yall know how to do that when we get there!

@AdharshKan42
Copy link
Contributor

Perfect, less rebasing for us :)

@AdharshKan42
Copy link
Contributor

AdharshKan42 commented Jan 31, 2024

@MattCMcCoy Merged main into our branch, removed our components from App.tsx as recommended by our glorious leader @Blais3D

Copy link
Contributor

@MattCMcCoy MattCMcCoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good nice job guys!

@Blais3D
Copy link
Collaborator

Blais3D commented Feb 1, 2024

Can we squash and merge this?

@MattCMcCoy
Copy link
Contributor

Can we squash and merge this?

Womp Womp

@MattCMcCoy MattCMcCoy merged commit c768a85 into main Feb 1, 2024
3 checks passed
@MattCMcCoy MattCMcCoy deleted the feature-generic-card-and-popup-modal branch February 1, 2024 20:38
andrewcaplan1 pushed a commit that referenced this pull request Feb 6, 2024
* Intial card/button

* Basic card and modal

Basic card and modal skeleton

* fixed card and popup to have the requirments

fixed card and popup to have the requirments

* wip for passing medication data into Card component

* trying to get stuff workin

* trying to get comps workin

* stuff

* Final Working Card + Popup

---------

Co-authored-by: AdharshKan42 <[email protected]>
oliviaseds added a commit that referenced this pull request Feb 17, 2024
* Added mock data

* feat: get tasks by gid/uid/status/type/date

* style: formatting

* fix: Remove commitizen branch

* test: fix task tests

* style: quick reformat

* feat: assign user(s) to a task CRUD and test

* style: quick style

* refactor: abstract queries, enable multiple

* refactor: abstract filter query/arg building logic

* crud routes for create new task, delete task, and update task info

* Feat: generic card and popup modal (#20)

* Intial card/button

* Basic card and modal

Basic card and modal skeleton

* fixed card and popup to have the requirments

fixed card and popup to have the requirments

* wip for passing medication data into Card component

* trying to get stuff workin

* trying to get comps workin

* stuff

* Final Working Card + Popup

---------

Co-authored-by: AdharshKan42 <[email protected]>

* fix: go formatting stuff werent running through entire directory (#23)

* feat: add a user context provider to the app (#24)

* feat: userContext stuff idk man

* refactor: general all around fixes (removing unused imports, fixing navigation errors)

* refactor: all over the place with this commit, but added swagger docs for file upload

* refactor: make context more general

* refactor: utilize card and popup in the medlist FE

* backend hot reload

* feat: added hot reloading for backend code

* refactor: abstract queries, enable multiple

* refactor: routes are updated

* feat: new route backend

* feat: add a new label crud and test

* feat: delete label crud and test

* refactor: FE  remove extra card file

* test: fix typo in db, tests passing locally

* refactor: modify task filter to bind to query

* feat: update task name and color route and test

* docs: fix swaggo comment style for task assignment and deletion

* docs: same swagger changes for label routes

* refactor: implement inclusive data range filter

* refactor: keep consistency between route groups

* docs: fix a swagger doc return type

---------

Co-authored-by: bedrockdude10 <[email protected]>
Co-authored-by: haleymartin-6 <[email protected]>
Co-authored-by: CaitlinFlynn <[email protected]>
Co-authored-by: AdharshKan42 <[email protected]>
Co-authored-by: Matt McCoy <[email protected]>
Co-authored-by: Matt McCoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants