Feat: FE Demo / How to prep #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just found the params field today, this change is to go with general SWE practices that a header is a field of an HTTP request or response that passes additional context and metadata about the request or response. For example, a request message can use headers to indicate it's preferred media formats, while a response can use header to indicate the media format of the returned body.
noticed that it marked the data as stale which refetches it automatically then I also manually refetched
MattCMcCoy
added
feature
…w coding styles mentioned in slack
Also, resolves an error in judgement I had with axios, onSuccess will never trigger with axios after a failing result. However it does happen with file upload as that seems to use another mode of transport.
andrewcaplan1
approved these changes
Feb 12, 2024
* feat: add eslint to fe * ci: utilize linter in fe workflow * refactor: revert usefile to const * style(prettier): use prettier for sorting imports over eslint * style: cleanup * ci: fix fe lint * refactor: useAuth to be const instead of function * feat: utilize colors from tailwind config to limit confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No ticket, just prep for a FE demo/how to for monday and rework Readme so it looks better
Notable changes in this PR:
useMedicationI think this is probably the cleanest way to go about it and genuinely makes me happy to avoid a bunch of use effects and such throughout each pageuseMedication definition
useMedication used
How Has This Been Tested?
Manually, seeing the changes in the app, and on AWS.
Checklist