-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/single task display screen #44
Conversation
Need to create API functionality for dynamic
Need to add v4 of the screen and need to handle button functionality
@@ -30,6 +31,15 @@ export function AppStackBottomTabNavigator() { | |||
}} | |||
component={GroupScreen} | |||
/> | |||
<AppStackBottomTab.Screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prolly shouldnt be apart of bottom nav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah for sure, just put it there so it'd be easy for me to access when testing on expo and since I didn't have access to the other task screens. I can just pull it out from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove from bottom nav?
package.json
Outdated
@@ -0,0 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra package.json not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:ahhhhhhhhh: forgot about that
Also can you fix merge conflicts? |
…o feature/single-task-display-screen
@MattCMcCoy sample task 1 displayed as shown. Lmk if there's any other changes that need to be made |
something happened while merging showing files you didnt edit? |
@MattCMcCoy I think I merged in your last commit before the PR got merged which is why it shows that it's showing files I didn't edit. In terms of changes it should still be the exact same as what you pushed in main. I also just removed the single task screen from the nav bar |
@narayansharma-21 what happens if you merge main into this? |
@MattCMcCoy I just merged main into my local and it just ran commitizen then made the merge but no files were changed edit: also pushed my merge to origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Link to Ticket (same ticket as before)