Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/type of task screen #45

Merged
merged 12 commits into from
Mar 16, 2024
Merged

Feature/type of task screen #45

merged 12 commits into from
Mar 16, 2024

Conversation

oliviaseds
Copy link
Contributor

@oliviaseds oliviaseds commented Mar 11, 2024 •
edited
Loading

Description

Type of Task Screen

Display task types and filter by category. Connect to previous screen and to specific task type creation screens (unimplemented).

How Has This Been Tested?

Run on Expo and connected with All Hands repository.

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

MattCMcCoy
MattCMcCoy reviewed Mar 15, 2024
View reviewed changes
client/navigation/AppNavigation.tsx Outdated
@@ -20,6 +22,11 @@ const AppStack = createNativeStackNavigator<AppStackParamList>();
export function AppNavigation() {
return (
<AppStack.Navigator>
<AppStack.Screen
name="TaskType"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merging can login be placed back in the first position?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doneeee

MattCMcCoy
MattCMcCoy approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@MattCMcCoy MattCMcCoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! :shipit:

Before squashing, can you move login to the first position in the nav stack? And Put the bottom nav container above it as well, so we can navigate

@MattCMcCoy
Copy link
Contributor

MattCMcCoy commented Mar 15, 2024 •
edited
Loading

Some thing you could add is the filter page closing after I select one, totally not necessary though I am good with the current state!

@oliviaseds oliviaseds merged commit 7eaf35f into main Mar 16, 2024
6 checks passed
@oliviaseds oliviaseds deleted the feature/task-type-frontend branch March 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattCMcCoy MattCMcCoy MattCMcCoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviaseds @MattCMcCoy