Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/task-list-screen #49

Closed
wants to merge 23 commits into from
Closed

Conversation

wyattchris
Copy link
Contributor

Description

Link to ticket

Screen that displays tasks for a given user/group -- allows for search for tasks based on metadata, filter tasks based on label, category, etc. Reusable task card component included.

How Has This Been Tested?

Merged the screen into the all hands branch and tested functionality and consistency with Expo & Postman. :D

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@wyattchris wyattchris requested a review from MattCMcCoy March 11, 2024 22:02
client/screens/TaskList.tsx Outdated Show resolved Hide resolved
client/screens/TaskList.tsx Show resolved Hide resolved
client/screens/TaskList.tsx Show resolved Hide resolved
client/screens/TaskList.tsx Show resolved Hide resolved
client/screens/TaskList.tsx Show resolved Hide resolved
client/screens/TaskList.tsx Outdated Show resolved Hide resolved
client/screens/TaskList.tsx Outdated Show resolved Hide resolved
@MattCMcCoy
Copy link
Contributor

Any chance you can make some data for group 5? For tasks/task labels and stuff?

@wyattchris wyattchris changed the title feat: migrated all changes from previous branch Feature/task-list-screen Mar 13, 2024
@wyattchris
Copy link
Contributor Author

  • when there's no tasks - filter page should remain at the bottom, and don't load the title if theres no tasks in that specified section
  • match what is on the figma, use the date package from PR comment
  • if filter button is selected, put it at the top (same component from profile increase roundness)
  • fix cutoff with marginbottom/padding in scroll view
  • more spacing + align section title with component

@MattCMcCoy
Copy link
Contributor

this has merge conflicts btw :( @wyattchris

@wyattchris
Copy link
Contributor Author

this has merge conflicts btw :( @wyattchris

on it good sir!!!

@MattCMcCoy
Copy link
Contributor

@wyattchris calendar was pushed do you have time to add that top nav on the calendar page, to navigate back and forth between calendar and task list?

@wyattchris
Copy link
Contributor Author

@wyattchris calendar was pushed do you have time to add that top nav on the calendar page, to navigate back and forth between calendar and task list?

yess definitely, i can work on that right now

@@ -29,7 +29,7 @@ VALUES
('8Sy7xBkGiGQv4ZKphcQfY8PxAqw1', 'Narayan', 'Sharma', '[email protected]', '', ''),
('iL7PnjS4axQffmlPceobjUUZ9DF2', 'Caitlin', 'Flynn', '[email protected]', '', ''),
('5JgN2PQxCRM9VoCiiFPlQPNqkL32', 'Linwood', 'Blaisdell', '[email protected]', '', ''),
('9rIMSUo6qNf8ToTABkCfNqnByRv1', 'Haley', 'Martin', '[email protected]', '', '')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you removed haley :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh snap 😭😭

);
}

const styles = StyleSheet.create({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tailwind!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slay

task_status: string;
task_type: string;
task_info?: string | null;
[key: string]: string | number | boolean | null | undefined; // Index signature for string indexing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you send a ss in slack to me and caplan how you indexed this?

@MattCMcCoy MattCMcCoy deleted the feature/task-list-screen-3 branch March 25, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants