feat: profile hifi #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattCMcCoy
commented
Mar 27, 2024
Comment on lines
+6
to
+7
| CREATE TYPE task_status AS ENUM ('INCOMPLETE', 'COMPLETE', 'INPROGRESS', | ||
| 'OVERDUE', 'TODO'); |
There was a problem hiding this comment.
Match designs wording
MattCMcCoy
commented
Mar 27, 2024
Comment on lines
+28
to
+34
| <View className="absolute -z-10 h-20 w-[100vw] bg-carewallet-white" /> | ||
| <SafeAreaView className="h-[100vh] flex-1"> | ||
| <PaperProvider> | ||
| <Router /> | ||
| </PaperProvider> | ||
| </SafeAreaView> | ||
| <View className="absolute -z-20 h-full w-[100vw] bg-carewallet-blue" /> |
There was a problem hiding this comment.
I am unsure of a better way to do this. There is white space below the SafeAreaView underneath the bottom nav without having an absolute bg blue view
MattCMcCoy
commented
Mar 27, 2024
Comment on lines
+18
to
+21
| fontFamily: { | ||
| 'carewallet-manrope': ['Manrope_400Regular'], | ||
| 'carewallet-manrope-semibold': ['Manrope_600SemiBold'], | ||
| 'carewallet-manrope-bold': ['Manrope_700Bold'] |
There was a problem hiding this comment.
This will be how we utilize different weights with the manrope font. unsure if its possible to not do this and be able to have the bold and semibold
MattCMcCoy
commented
Mar 27, 2024
Comment on lines
+64
to
+68
| onTouchEnd={() => { | ||
| navigation.navigate('CalendarContainer', { | ||
| screen: 'CalendarTopNav', | ||
| params: { screen: 'TaskList' } | ||
| }); |
There was a problem hiding this comment.
fixes nested navigation bug where you wouldnt be able to navigate from profile to task list if task list isnt visted first
andrewcaplan1
approved these changes
Mar 29, 2024
andrewcaplan1
pushed a commit
that referenced
this pull request
Apr 5, 2024
* feat: profile hifi * refactor: utilize googlefont package * fix: fix bug where you couldnt directly navigate to task list if it wasnt loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
Transitioned Profile Page to HIFI
How Has This Been Tested?
I visually look at HiFi
Screen.Recording.2024-03-27.at.1.07.37.PM.mov
FIGMA
Checklist