Feature/file upload screen #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yooo @wyattchris can you fix merge conflicts with this? |
MattCMcCoy
suggested changes
Apr 3, 2024
MattCMcCoy
reviewed
Apr 3, 2024
MattCMcCoy
reviewed
Apr 3, 2024
MattCMcCoy
reviewed
Apr 3, 2024
package.json
Outdated
Comment on lines
1
to
6
| { | ||
| "dependencies": { | ||
| "@expo-google-fonts/manrope": "^0.2.3", | ||
| "@expo-google-fonts/montserrat": "^0.2.3" | ||
| } | ||
| } |
There was a problem hiding this comment.
can you remove this and run task build
MattCMcCoy
reviewed
Apr 3, 2024
client/services/task.ts
Outdated
Comment on lines
24
to
30
| export const getLabelsByGroup = async ( | ||
| groupID: number | ||
| ): Promise<TaskLabel[]> => { | ||
| const { data } = await axios.get(`${api_url}/group/${groupID}/labels`); | ||
| return data; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Any reason for not usin tan stack?
MattCMcCoy
reviewed
Apr 3, 2024
| @@ -11,9 +11,9 @@ export function BackButton() { | |||
|
|
|||
| return ( | |||
| <IconButton | |||
| className="align-center m-2 flex h-[50px] w-[52px] justify-center rounded-xl border border-carewallet-lightgray bg-carewallet-white" | |||
| className="align-center m-2 flex h-[50px] w-[52px] justify-center rounded-xl bg-carewallet-blue" | |||
There was a problem hiding this comment.
I would make sure this matches all the current pages that are hifis right now, seems its applying a blue background I think it should be white (at least for profile which is in the app rn)
MattCMcCoy
reviewed
Apr 3, 2024
| @@ -8,6 +8,7 @@ export type AppStackParamList = { | |||
| Profile: undefined; | |||
| PatientView: undefined; | |||
| ProfileScreens: undefined; | |||
| FileUploadScreen: undefined; | |||
There was a problem hiding this comment.
can you add the ability to navigate to file upload screen in the patient view theres already a button for it?
fix: show image on select, virtualized list error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to Ticket
Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!
Screen to upload files! edited routes, DB, + tanstack to include labels + additional notes.
How Has This Been Tested?
Tested backend routes + DB via Swagger, tested FE uploading locally with Expo
Checklist