Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron build + Router Updates #22

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Electron build + Router Updates #22

merged 6 commits into from
Feb 20, 2024

Conversation

hmcclew
Copy link
Contributor

@hmcclew hmcclew commented Feb 20, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Updating electon versioning to fix mac compatibilities and implementing conditions to check the environment and use proper routers accordingly. Also separating electron build to run from build directory instead of having to run local host.

Fixes # (issue)

N/a

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
If they are unit tests, provide the file name the tests are in.
If they are not unit tests, describe how you tested the change.

Tested in browser + in electron

Checklist:

  • [ X] I have performed a self-review of my code
  • [X ] I have reached out to another developer to review my code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] New and existing unit tests pass locally with my changes

@hmcclew hmcclew merged commit 3ce1642 into main Feb 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant