28 registration and unregistration #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammotts
reviewed
Oct 6, 2025
|
|
||
| @router.post("/new", response_model=Registration) | ||
| async def create_registrion( | ||
| registration: Annotated[CreateRegistrationRequest, Body(...)], |
There was a problem hiding this comment.
Might not need a whole CreateRegistrationRequest to just store the event_id but this is just a nit so no need to fix
adammotts
approved these changes
Oct 6, 2025
|
See comments I left in Slack thread about upserting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to Ticket
This PR is about users registering and unregistering for events. This is important functionality for the central use of our app. When registering, a new registration is created. When unregistering, that registration is fed in, and gets changed to the status: "unregistered" from "upcoming"
How Has This Been Tested?
I tried both endpoints on Swagger as a user with the volunteer type
Checklist