Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Task scripts to Nix scripts #22

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Move Task scripts to Nix scripts #22

merged 1 commit into from
Sep 21, 2024

Conversation

jtrrll
Copy link
Contributor

@jtrrll jtrrll commented Sep 20, 2024 •
edited
Loading

I moved your useful Taskfile targets to the Nix devshell (and made them slightly prettier). Totally optional if you want to merge this, but IMO it's a small quality of life upgrade

image

@jtrrll jtrrll requested a review from ddusichka September 20, 2024 04:50
@ddusichka
Copy link
Collaborator

much appreciated @jtrrll thank you 🙂

one thing - one engineer mentioned having issues with Nix caching his files so his work wasn’t being reflected when running the backend. he ended up running our original ‘task backend:clean’ between each restart of the server and it fixed it, but he said @garrettladley mentioned we could make updates to the task file (I guess now technically our nix setup) to prevent this

do you guys have thoughts on the best way to fix this here? should we just incorporate the rm -f server command from the old backend:clean directly into the new run command or is there a better way

@jtrrll
Copy link
Contributor Author

jtrrll commented Sep 20, 2024 •
edited
Loading

one engineer mentioned having issues with Nix caching his files so his work wasn’t being reflected when running the backend. he ended up running our original ‘task backend:clean’ between each restart of the server and it fixed it, but he said @garrettladley mentioned we could make updates to the task file (I guess now technically our nix setup) to prevent this

Seems like there is some confusion with how the build system works... Nix isn't caching anything, it's technically task. In your old taskfile, run is dependent on build. This means that if you run, and the binary is already built, taskfile does NOT re-run build (which is where the supposed "cache" behavior is coming from)

Luckily, the new run script I wrote in Nix uses go run ... rather than go build ... && ./server. This way, the script will always recompile with the developer's changes before running. Additionally, I combined run and watch, so you should get hot reloading as well.

@ddusichka
Copy link
Collaborator

one engineer mentioned having issues with Nix caching his files so his work wasn’t being reflected when running the backend. he ended up running our original ‘task backend:clean’ between each restart of the server and it fixed it, but he said @garrettladley mentioned we could make updates to the task file (I guess now technically our nix setup) to prevent this

Seems like there is some confusion with how the build system works... Nix isn't caching anything, it's technically task. In your old taskfile, run is dependent on build. This means that if you run, and the binary is already built, taskfile does NOT re-run build (which is where the supposed "cache" behavior is coming from)

Luckily, the new run script I wrote in Nix uses go run ... rather than go build ... && ./server. This way, the script will always recompile with the developer's changes before running. Additionally, I combined run and watch, so you should get hot reloading as well.

that makes a lot more sense!! sounds good, this definitely feels cleaner then

@ddusichka ddusichka merged commit 4f7e72c into main Sep 21, 2024
4 of 8 checks passed
@ddusichka ddusichka deleted the env-help-bump branch September 21, 2024 15:17
adescoteaux1 pushed a commit that referenced this pull request Sep 24, 2024
Squashed commit of the following:
6d75f10 
commit 722541a
Author: Dessy Dusichka <[email protected]>
Date:   Mon Sep 23 21:09:01 2024 -0400

    Adding docs on making schema changes, updating contributing docs (#26)

    * docs updates

    * remove unnecessary info

commit 403be01
Author: Luisa <[email protected]>
Date:   Mon Sep 23 19:23:39 2024 -0400

    Get reviews for user (#20)

    Me when reviews are retrieved by user ids

commit ec0ab7a
Merge: f33718a 22b4ed7
Author: gaikwadsid <[email protected]>
Date:   Mon Sep 23 17:18:14 2024 -0400

    Merge pull request #24 from GenerateNU/rest_of_schema

    Rest of schema

commit f33718a
Author: aahil nishad <[email protected]>
Date:   Mon Sep 23 16:21:22 2024 -0400

    Create new review endpoint & review types. (#27)

    * feat: add create review endpoint

    * refactor: fix error handling for create review

    * refactor: make handlers more modular

    * fix: update query to handle edge cases

    * fix: check userid is valid when creating review

    * fix: make pr changes

    * revert update to og script

    ---------

    Co-authored-by: aaronkimbrooktec <[email protected]>
    Co-authored-by: ddusichka <[email protected]>

commit 7ae380f
Author: Dessy Dusichka <[email protected]>
Date:   Mon Sep 23 00:10:47 2024 -0400

    Add nix scripts to lint and run frontend (#28)

    * add scripts for frontend

    * allow console for now and remove test action

    * make prettier happy

    * one more try

commit 22b4ed7
Author: gaikwadsid <[email protected]>
Date:   Sun Sep 22 18:57:24 2024 -0400

    Example for new script

commit e99e4ea
Author: gaikwadsid <[email protected]>
Date:   Sun Sep 22 00:09:46 2024 -0400

    Connected Frontend to Backend (#23)

    * Connected Frontend to Backend

    * Fixed lint?

    * Fix lint

    * Fix lint

    * Fix lint

    * Fix lint

    * Fix lint

    * Fix lint?

    * Fix lint

    * Fix lint

    * prettier fix?

    * lint fix

    * fix lint.

    * Deleted .env file

    ---------

    Co-authored-by: ddusichka <[email protected]>

commit e783ffe
Author: ddusichka <[email protected]>
Date:   Sun Sep 22 00:04:59 2024 -0400

    pause frontend tests

commit 551b292
Author: gaikwadsid <[email protected]>
Date:   Sat Sep 21 21:49:17 2024 -0400

    Fixed syntax errrors

commit df13718
Author: Dessy Dusichka <[email protected]>
Date:   Sat Sep 21 14:48:00 2024 -0400

    Update pull_request_template.md

commit 4f7e72c
Merge: 9816b83 70dd930
Author: Dessy Dusichka <[email protected]>
Date:   Sat Sep 21 11:17:01 2024 -0400

    Merge pull request #22 from GenerateNU/env-help-bump

    Move Task scripts to Nix scripts

commit cefc909
Author: gaikwadsid <[email protected]>
Date:   Fri Sep 20 22:17:35 2024 -0400

    Added data into the tables

commit 9816b83
Merge: 09b17a6 5cfb658
Author: Dessy Dusichka <[email protected]>
Date:   Fri Sep 20 13:27:13 2024 -0400

    Merge pull request #18 from GenerateNU/spotify-oauth-v2

    feat: spotify oauth

commit 70dd930
Author: Jackson Terrill <[email protected]>
Date:   Fri Sep 20 00:49:03 2024 -0400

    Move Task scripts to Nix scripts

commit b663684
Author: gaikwadsid <[email protected]>
Date:   Thu Sep 19 18:38:06 2024 -0400

    Added rest of schema

commit 5cfb658
Merge: 540e431 09b17a6
Author: aaronkimbrooktec <[email protected]>
Date:   Thu Sep 19 17:41:00 2024 -0400

    Merge remote-tracking branch 'origin' into spotify-oauth-v2

commit 540e431
Author: aaronkimbrooktec <[email protected]>
Date:   Thu Sep 19 17:40:53 2024 -0400

    refactor: make oauth sessionvalue store available to all providers

commit 09b17a6
Author: gaikwadsid <[email protected]>
Date:   Thu Sep 19 17:22:18 2024 -0400

    Update pull_request_template.md

commit f98e84a
Author: gaikwadsid <[email protected]>
Date:   Thu Sep 19 17:20:53 2024 -0400

    Update pull_request_template.md

commit d8d6996
Author: aaronkimbrooktec <[email protected]>
Date:   Thu Sep 19 16:15:53 2024 -0400

    refactor: rename and reorganize some things

commit 1fe560a
Author: garrettladley <[email protected]>
Date:   Thu Sep 19 11:47:29 2024 -0400

    feat: back to sessions

commit 5752469
Author: ddusichka <[email protected]>
Date:   Thu Sep 19 10:48:35 2024 -0400

    make favicon error go away

commit 1264a6b
Author: garrettladley <[email protected]>
Date:   Thu Sep 19 09:50:06 2024 -0400

    feat: don't keep track of challenge on our end, clean up, and TODO resolved

commit 01f9218
Merge: eab21a4 ead556c
Author: Garrett Ladley <[email protected]>
Date:   Wed Sep 18 23:45:49 2024 -0400

    Merge branch 'main' into spotify-oauth-v2

commit ead556c
Author: Aaron Kim <[email protected]>
Date:   Wed Sep 18 23:45:17 2024 -0400

    feat: add central error handling (#19)

commit eab21a4
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:17:37 2024 -0400

    nit: make stateValue fields unexported

commit d9c9ddd
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:16:02 2024 -0400

    fix: lint?

commit 9f2b184
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:15:12 2024 -0400

    fix: lint?

commit 079f0be
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:11:40 2024 -0400

    fix: lint?

commit 71ccfab
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:10:14 2024 -0400

    fix: lint?

commit 11ce351
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:05:16 2024 -0400

    fix: check err value of set

commit f93510b
Author: garrettladley <[email protected]>
Date:   Wed Sep 18 23:00:54 2024 -0400

    feat: kv with state as the key and verifier x challenge as the value

commit 72ef134
Author: aaronkimbrooktec <[email protected]>
Date:   Wed Sep 18 17:33:52 2024 -0400

    feat: spotify oauth

commit 0a567be
Author: Dessy Dusichka <[email protected]>
Date:   Wed Sep 18 20:52:41 2024 -0400

    Create pull_request_template.md

commit 648ad3f
Merge: 37c4fad 7c69270
Author: gaikwadsid <[email protected]>
Date:   Tue Sep 17 22:30:00 2024 -0400

    Merge pull request #16 from GenerateNU/add-schema

    Setting up database tables and seed data

commit 7c69270
Author: ddusichka <[email protected]>
Date:   Tue Sep 17 22:15:37 2024 -0400

    add unique constraint

commit 13c9527
Author: ddusichka <[email protected]>
Date:   Tue Sep 17 15:00:01 2024 -0400

    update ID types and seed data

commit c1feea9
Author: ddusichka <[email protected]>
Date:   Mon Sep 16 22:55:43 2024 -0400

    setting up schema and seed data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddusichka ddusichka ddusichka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtrrll @ddusichka