Skip to content

Polish pt. 1 - going to submit a pr #528

Polish pt. 1 - going to submit a pr

Polish pt. 1 - going to submit a pr #528

Triggered via push April 17, 2024 23:51
Status Failure
Total duration 48s
Artifacts

mobile.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L1
Replace `ClubTags·}·from·"@/hooks/use-club-tags";⏎import·{·Club·}·from·"@/types/club";⏎import·{·useState,·useEffect·}·from·"react"` with `Effect,·useState·}·from·'react'`
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L3
'useState' is defined but never used
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L3
'useEffect' is defined but never used
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L4
Replace `"react-native"` with `'react-native';⏎⏎import·{·useClubTags·}·from·'@/hooks/use-club-tags';⏎import·{·Club·}·from·'@/types/club'`
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L14
Replace `·data:·tags,·isLoading,·error·}·=·useClubTags(p.club·?·p.club.id·:·"tester"` with `⏎········data:·tags,⏎········isLoading,⏎········error⏎····}·=·useClubTags(p.club·?·p.club.id·:·'tester'`
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L16
Replace `·!isLoading·&&·error·==·null` with `⏎········!isLoading·&&·error·==·null⏎···········`
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L16
'ind' is defined but never used. Allowed unused args must match /^_/u
Lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Lint: frontend/sac-mobile/app/(app)/event/_components/location-view.tsx#L59
Inline style: { width: '100%' }
Lint: frontend/sac-mobile/app/(app)/event/_layout.tsx#L23
Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “EventLayout” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
Lint: frontend/sac-mobile/app/(app)/event/_layout.tsx#L26
Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “EventLayout” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
Lint: frontend/sac-mobile/app/(app)/event/_layout.tsx#L27
Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “EventLayout” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L31
Empty components are self-closing
Lint: frontend/sac-mobile/app/(app)/search/_components/club-card.tsx#L46
Empty components are self-closing
Lint: frontend/sac-mobile/app/(app)/search/_components/search-bar.tsx#L57
Expected '===' and instead saw '=='
Lint: frontend/sac-mobile/app/(app)/search/_components/search-bar.tsx#L62
Empty components are self-closing
Lint: frontend/sac-mobile/app/(app)/search/_components/top-search.tsx#L19
Empty components are self-closing
Lint: frontend/sac-mobile/app/(app)/search/discover.tsx#L23
Inline style: { display: 'flex', flexDirection: 'column' }
Format
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.