test: putContact

GenerateNU · Feb 5, 2024 · 0ab3153 · 0ab3153
1 parent abde0e8
commit 0ab3153
Show file tree

Hide file tree

Showing 5 changed files with 179 additions and 628 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -0,0 +1,7 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": []
+}
diff --git a/backend/src/models/contact.go b/backend/src/models/contact.go
@@ -20,14 +20,15 @@ const (
 type Contact struct {
 	Model
 
-	Type    ContactType `gorm:"type:varchar(255)" json:"type" validate:"required,max=255"`
-	Content string      `gorm:"type:varchar(255)" json:"content" validate:"required,contact_pointer,max=255"`
+	Type    ContactType `gorm:"type:varchar(255);uniqueIndex:idx_contact_type" json:"type" validate:"required,max=255,oneof=facebook instagram twitter linkedin youtube github slack discord email customSite"`
+	Content string      `gorm:"type:varchar(255);" json:"content" validate:"required,max=255"`
 
-	ClubID uuid.UUID `gorm:"foreignKey:ClubID" json:"-" validate:"uuid4"`
+	ClubID uuid.UUID `gorm:"foreignKey:ClubID;uniqueIndex:idx_contact_type" json:"-" validate:"uuid4"`
 }
 
 type PutContactRequestBody struct {
-	Type    ContactType  `gorm:"type:varchar(255)" json:"type" validate:"required,max=255"`
-	Content string `gorm:"type:varchar(255)" json:"content" validate:"required,url,max=255"`
-	ClubID  uint   `gorm:"foreignKey:ClubID" json:"-" validate:"min=1"`
+	Type    ContactType  `gorm:"type:varchar(255)" json:"type" validate:"required,max=255,oneof=facebook instagram twitter linkedin youtube github slack discord email customSite"`
+
+	//TODO content  validator
+	Content string `gorm:"type:varchar(255)" json:"content" validate:"required,s3_url,max=255"`
 }
diff --git a/backend/src/services/club.go b/backend/src/services/club.go
@@ -135,11 +135,7 @@ func (c *ClubService) PutContact(clubID string, contactBody models.PutContactReq
 	if err != nil {
 		return nil, &errors.FailedToMapRequestToModel
 	}
-
-	if *idAsUUID != contact.ClubID {
-		return nil, &errors.FailedToUpdateContact
-	}
-
+	contact.ClubID = *idAsUUID
 	return transactions.PutContact(c.DB, *idAsUUID, *contact)
 }
 

diff --git a/backend/src/transactions/club.go b/backend/src/transactions/club.go
@@ -91,7 +91,7 @@ func GetClubContacts(db *gorm.DB, id uuid.UUID) ([]models.Contact, *errors.Error
 
 func PutContact(db *gorm.DB, clubID uuid.UUID, contact models.Contact) (*models.Contact, *errors.Error) {
 	err := db.Clauses(clause.OnConflict{
-		Columns:   []clause.Column{{Name: "type"}},
+		Columns:   []clause.Column{{Name: "club_id"}, {Name: "type"}},
 		DoUpdates: clause.AssignmentColumns([]string{"content"}),
 	}).Create(&contact).Error
 	if err != nil {