Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAC Club Point of Contact CRUD #195

Closed
wants to merge 19 commits into from

Conversation

akshayd2020
Copy link
Contributor

Description

[Link to Ticket](insert the link to your ticket inside the parenthesis here)

Please include a summary of the changes and the related issue. Please also
include relevant motivation, context, and images!

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If they are unit
tests, provide the file name the tests are in. If they are not unit tests,
describe how you tested the change.

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

backend/src/services/club.go Fixed Show fixed Hide fixed
backend/src/services/club.go Fixed Show fixed Hide fixed

downloader := s3manager.NewDownloader(sess)

downloadedFile, err := os.Create(file.FileName)

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.

downloadedFile, err := os.Create(file.FileName)

_, err = downloader.Download(downloadedFile,

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.
@garrettladley garrettladley marked this pull request as ready for review February 17, 2024 20:33
}

}
pointOfContact.ClubID = *clubIdAsUUID

Check warning

Code scanning / CodeQL

Missing error check Warning

clubIdAsUUID
may be nil at this dereference because
idErr
may not have been checked.
@DOOduneye DOOduneye closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants