SAC-7 Delete User DELETE #36

in-mai-space · 2024-01-20T22:56:30Z

Description

Link to Ticket

Implements DELETE for user

How Has This Been Tested?

Successful delete (200)
User Does Not Exist (404)
Invalid string ID (400)
Negative ID (400)
Database Disconnected (500)

Checklist

I have performed a self-review of my code
I have reached out to another developer to review my code
I have commented my code, particularly in hard-to-understand areas
New and existing unit tests pass locally with my changes

DOOduneye

Looks great, just some small nitpicks

backend/src/controllers/user.go

backend/tests/api/user_test.go

backend/src/services/user.go

backend/src/controllers/user.go

backend/src/transactions/user.go

garrettladley

nits but great work team 👏

Co-authored-by: Melody Yu <[email protected]> Co-authored-by: Garrett Ladley <[email protected]> Co-authored-by: Zackary Lassetter <[email protected]> Co-authored-by: edwinliiiii <[email protected]> Co-authored-by: edwinliiiii <[email protected]> Co-authored-by: garrettladley <[email protected]> Co-authored-by: David Oduneye <[email protected]> Co-authored-by: David Oduneye <[email protected]>

kamillengn and others added 6 commits January 19, 2024 15:55

Add DELETE user in transactions

9eb96a1

initial delete commit

2994041

Merge branch 'main' into SAC-7-DeleteUser-DELETE

be70889

Merge branch 'main' into SAC-7-DeleteUser-DELETE

25048aa

Edit test cases

c8a891e

Final user test updates

e7f7310

github-actions bot assigned in-mai-space Jan 20, 2024

garrettladley requested review from a team, sunnyh2024, edwinliiiii, DOOduneye and garrettladley and removed request for a team January 20, 2024 22:56

Refactor some of the test cases

fdf9de4

garrettladley assigned sunnyh2024 Jan 21, 2024

Merge branch 'main' into SAC-7-DeleteUser-DELETE

a102026

DOOduneye suggested changes Jan 21, 2024

View reviewed changes

backend/src/controllers/user.go Outdated Show resolved Hide resolved

backend/src/controllers/user.go Outdated Show resolved Hide resolved

backend/tests/api/user_test.go Show resolved Hide resolved

backend/src/services/user.go Outdated Show resolved Hide resolved

garrettladley reviewed Jan 22, 2024

View reviewed changes

backend/src/controllers/user.go Outdated Show resolved Hide resolved

garrettladley reviewed Jan 22, 2024

View reviewed changes

backend/src/transactions/user.go Outdated Show resolved Hide resolved

garrettladley reviewed Jan 22, 2024

View reviewed changes

backend/src/transactions/user.go Outdated Show resolved Hide resolved

garrettladley requested changes Jan 22, 2024

View reviewed changes

sunnyh2024 and others added 7 commits January 22, 2024 00:54

fix comments

7172306

Merge branch 'main' into SAC-7-DeleteUser-DELETE

46f9284

add validator call

83a6d88

linting errors

f520844

Merge branch 'main' into SAC-7-DeleteUser-DELETE

0570f00

fix ci tests?

f4ddf1b

refactor: design to increase standardization

124ce5b

kamillengn and others added 19 commits January 22, 2024 15:33

Add DELETE user in transactions

7bf1803

initial delete commit

0e1eb27

Edit test cases

8b7ec2f

Final user test updates

a85d057

Refactor some of the test cases

f343e71

fix comments

597aaee

add validator call

17a950a

linting errors

9b29416

fix ci tests?

656c1e5

refactor: design to increase standardization

551bdff

refactor: design to increase standardization

2427d62

Update auto_request_review.yml

383ce0e

Validator singleton (#43)

ced3190

Add DELETE user in transactions

bffe1e4

rebase

afb19c2

rebase

1879632

rebase

296f106

Merge branch 'main' into SAC-7-DeleteUser-DELETE

2956136

garrettladley merged commit 08cb5c0 into main Jan 22, 2024
4 of 6 checks passed

garrettladley deleted the SAC-7-DeleteUser-DELETE branch January 22, 2024 22:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SAC-7 Delete User DELETE #36

SAC-7 Delete User DELETE #36

in-mai-space commented Jan 20, 2024

DOOduneye left a comment

garrettladley left a comment

SAC-7 Delete User DELETE #36

SAC-7 Delete User DELETE #36

Conversation

in-mai-space commented Jan 20, 2024

Description

How Has This Been Tested?

Checklist

DOOduneye left a comment

Choose a reason for hiding this comment

garrettladley left a comment

Choose a reason for hiding this comment