Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator singleton #43

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Validator singleton #43

merged 2 commits into from
Jan 22, 2024

Conversation

michael-brennan2005
Copy link
Contributor

@michael-brennan2005 michael-brennan2005 commented Jan 22, 2024 •
edited by DOOduneye
Loading

Description

validate.Validator needs to be made a singleton that is then used for all validation, so validation tags get cached for performance benefits.

How Has This Been Tested?

n/a

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@garrettladley garrettladley requested review from a team, zacklassetter and ojn03 and removed request for a team January 22, 2024 18:24
DOOduneye
DOOduneye approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@DOOduneye DOOduneye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DOOduneye DOOduneye merged commit 83bb7cf into main Jan 22, 2024
8 checks passed
@DOOduneye DOOduneye deleted the validator-singleton branch January 22, 2024 19:12
DOOduneye pushed a commit that referenced this pull request Jan 22, 2024
@michael-brennan2005 @DOOduneye
Validator singleton (#43)
ced3190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DOOduneye DOOduneye DOOduneye approved these changes

@zacklassetter zacklassetter Awaiting requested review from zacklassetter

@ojn03 ojn03 Awaiting requested review from ojn03

@garrettladley garrettladley Awaiting requested review from garrettladley

Assignees

@michael-brennan2005 michael-brennan2005

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-brennan2005 @DOOduneye