Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: redis #859

Merged
merged 13 commits into from
May 28, 2024
Merged

feat: redis #859

merged 13 commits into from
May 28, 2024

Conversation

DOOduneye
Copy link
Contributor

@DOOduneye DOOduneye commented May 20, 2024 •
edited
Loading

No description provided.

@DOOduneye DOOduneye changed the title Redis feat: redis May 21, 2024
@DOOduneye DOOduneye marked this pull request as ready for review May 21, 2024 19:57
@garrettladley garrettladley requested review from a team and garrettladley and removed request for a team May 21, 2024 19:57
This was linked to issues May 21, 2024
chore: clean up backend/auth/jwt.go #640
Closed
feat: auth #706
Closed
garrettladley
garrettladley requested changes May 23, 2024
View reviewed changes
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cooked @DOOduneye 👨‍🍳 !!! great use of interfaces 👑 some nits then looks good to merge

backend/config/redis.go Show resolved Hide resolved
backend/database/store/blacklist.go Outdated Show resolved Hide resolved
backend/database/store/blacklist.go Outdated Show resolved Hide resolved
backend/database/store/blacklist.go Outdated Show resolved Hide resolved
backend/database/store/redis.go Outdated Show resolved Hide resolved
backend/entities/auth/base/routes.go Outdated Show resolved Hide resolved
backend/entities/auth/base/service.go Outdated Show resolved Hide resolved
backend/entities/auth/base/service.go Outdated Show resolved Hide resolved
backend/entities/auth/base/service.go Outdated Show resolved Hide resolved
backend/entities/auth/base/service.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 23, 2024
View reviewed changes
config/local.yml
- username: redis_active_tokens
host: 127.0.0.1
port: 6379
password: redis_active_token!#1

Check failure

Code scanning / CodeQL

Password in configuration file

Hard-coded password 'redis_active_token!#1' in configuration file.
config/local.yml
- username: redis_blacklist
host: 127.0.0.1
port: 6380
password: redis_blacklist!#2

Check failure

Code scanning / CodeQL

Password in configuration file

Hard-coded password 'redis_blacklist!#2' in configuration file.
config/local.yml
- username: redis_limiter
host: 127.0.0.1
port: 6381
password: redis_limiter!#3

Check failure

Code scanning / CodeQL

Password in configuration file

Hard-coded password 'redis_limiter!#3' in configuration file.
@garrettladley garrettladley self-requested a review May 28, 2024 02:21
garrettladley
garrettladley approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good stuff @DOOduneye

@garrettladley garrettladley enabled auto-merge (squash) May 28, 2024 02:21
@garrettladley garrettladley merged commit 86f8051 into main May 28, 2024
5 checks passed
@garrettladley garrettladley deleted the redis branch May 28, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettladley garrettladley garrettladley approved these changes

Assignees

@DOOduneye DOOduneye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: auth chore: clean up backend/auth/jwt.go
2 participants
@DOOduneye @garrettladley