Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rich text editor #892

Closed
wants to merge 14 commits into from
Closed

feat: rich text editor #892

wants to merge 14 commits into from

Conversation

in-mai-space
Copy link
Contributor

@in-mai-space in-mai-space commented May 24, 2024

Description

Link to Ticket

Rich text editor for mobile and dashboard using Tiptap and Tentap

How Has This Been Tested?

No tests

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@in-mai-space in-mai-space self-assigned this May 24, 2024
@@ -1,31 +1,32 @@
import React from 'react';

import { Tabs } from 'expo-router';
import { SafeAreaProvider } from 'react-native-safe-area-context';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import SafeAreaProvider.
@@ -1,18 +1,21 @@
import { StyleSheet, Text, View } from 'react-native';
import { StyleSheet, Text, View, SafeAreaView } from 'react-native';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports Text, View.
import { StyleSheet, Text, View, SafeAreaView } from 'react-native';
import React from "react";
import {Editor} from "../../components/editor/editor";
import { SafeAreaProvider } from 'react-native-safe-area-context';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import SafeAreaProvider.
@@ -0,0 +1,38 @@
import {BubbleMenu} from '@tiptap/react';
import { Editor } from '@tiptap/react'
import { Bold, Heading1, Heading2, Italic, ListIcon, ListOrdered, UnderlineIcon } from 'lucide-react';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports ListOrdered, UnderlineIcon.
@@ -12,6 +11,7 @@
import { ThemeProvider } from '@shopify/restyle';

import { store } from '@/store/store';
import { SafeAreaProvider } from 'react-native-safe-area-context';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import SafeAreaProvider.
@garrettladley garrettladley requested review from a team, DOOduneye and garrettladley and removed request for a team May 24, 2024 12:50
@alderwhiteford
Copy link
Contributor

could you add videos of the editors to the PR? Thanks!

}

export const Toolbar: React.FC<ToolbarProps> = ({ editor }) => {
const [json, setJSON] = useState("")

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable json.
Copy link
Member

@garrettladley garrettladley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits the LGMT
keep up the great work on the frontend @in-mai-space 🐐

@@ -19,7 +19,7 @@ node_modules
backend/tests/api/__debug_*
.env.prod

frontend/mobile/ios/
# frontend/mobile/ios/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add this line back in?

frontend/package-lock.json Outdated Show resolved Hide resolved
@in-mai-space in-mai-space deleted the rich-text-editor branch June 11, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants