📝 feat: update club models #911
Conversation
…ansactions soc clean up
garrettladley
requested review from
a team and
DOOduneye
and removed request for
a team
There was a problem hiding this comment.
Fantastic! I think my big comment is about extensibility. I think a club should have a many recruiting objects.
Each recruiting object is a certain set of people theyre recruiting like software engineers vs designers vs things that are external like clubs like generate have applications for clients but you're not becoming a member from it.
| @@ -0,0 +1,180 @@ | |||
| package leadership | |||
There was a problem hiding this comment.
if we're switching to leadership as a term, we should also remove the term "poc" so lID instead of pocID and etc
|
|
||
| type CreatePointOfContactBody struct { | ||
| type CreateLeaderBody struct { |
There was a problem hiding this comment.
nit but should this be leadership instead of leader? leader implies something different
| Name string `json:"name" validate:"required,max=255"` | ||
| Email string `json:"email" validate:"required,email,max=255"` | ||
| Position string `json:"position" validate:"required,max=255"` | ||
| } | ||
|
|
||
| type UpdatePointOfContactBody struct { | ||
| type UpdateLeaderBody struct { |
There was a problem hiding this comment.
same as above and anytime the term leader is used over leadership
|
@DOOduneye what i went with was Leadership is the plural of Leader |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
prior to merge