feat: navbar & club info tag component #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettladley
requested review from
a team,
DOOduneye and
garrettladley
and removed request for
a team
There was a problem hiding this comment.
@TylerSchaefer4 do we want to host our components beneath design-system?
garrettladley
requested changes
May 27, 2024
There was a problem hiding this comment.
some nits and looking for @TylerSchaefer4's feedback. keep up the great work @in-mai-space 👑
| tabBarShowLabel: true, | ||
| tabBarStyle: { | ||
| borderTopWidth: 1, | ||
| borderTopColor: '#00000066', |
There was a problem hiding this comment.
avoid hardcoding colors. Either use black or add this to the color theme config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navbar
Club info tag
Navbar and club info tag component.
How Has This Been Tested?
No tests.
Checklist