Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): add conftest.py #81

Merged
merged 1 commit into from
Jan 2, 2025
Merged

feat(python): add conftest.py #81

merged 1 commit into from
Jan 2, 2025

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Jan 2, 2025 •
edited
Loading

Motivated by two things

  • the "noisy logs" thing really is annoying in a lot of our stuff and it'd be nice to have the code there to handle it. Easy to delete where it's really unnecessary
  • I wanted to add a set of tests to the FastAPI branch I'm working on, but the template doesn't currently include any tests by default, so I wanted to have a little bit of a skeleton there.

@jsstevenson jsstevenson added the priority:medium Medium priority label Jan 2, 2025
@korikuzma korikuzma self-requested a review January 2, 2025 15:50
korikuzma
korikuzma approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@jsstevenson jsstevenson merged commit 3f458e3 into main Jan 2, 2025
3 of 4 checks passed
@jsstevenson jsstevenson deleted the add-python-tests branch January 2, 2025 16:39
@jsstevenson jsstevenson mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsstevenson @korikuzma