Merge pull request #46 from sgaland/cleaner_slack_post

Only show KO on Slack if relevant
Genymobile · Aug 21, 2015 · 5267193 · 5267193
2 parents 2f59531 + c4daaf5
commit 5267193
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/bot/tasks.py b/bot/tasks.py
@@ -46,11 +46,14 @@ def slack(url, org, weburl, repos, slackurl, channel):
                     txt += " *%s* -" % (pr.milestone)
                 for label in pr.labels:
                     txt += " *%s* -" % (label['name'])
-                txt += " %s review:%d %s:%d %s:%d %s:%d\n" % \
+                txt += " %s review:%d %s:%d %s:%d" % \
                        (pr.user, pr.nbreview,
                         settings.FEEDBACK_OK['keyword'], pr.feedback_ok,
-                        settings.FEEDBACK_WEAK['keyword'], pr.feedback_weak,
-                        settings.FEEDBACK_KO['keyword'], pr.feedback_ko)
+                        settings.FEEDBACK_WEAK['keyword'], pr.feedback_weak)
+                if pr.feedback_ko > 0:
+                    txt += " %s" % (settings.FEEDBACK_KO['keyword'])
+                txt += "\n"
+
 
 
     payload = {"channel": channel,