upgrade to BH (>= 1.87.0-1) #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rsbivand Wow this looks great! Thank you so much for this PR! I truly appreciate it. |
|
CRAN submission will be offline from Dec 23, 2024 to Jan 07, 2025 (CRAN team vacation and maintenance work). |
|
Thanks for the heads up! I just tested it on Win-devel and made a submission to CRAN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lixun910 @lanselin This should be good to go now that the
BHpackage was upgraded to 1.81.0-1 yesterday. It may still fail on Windows, as the new package version propagates. Errors in braces in roxygen also fixed. Including Boost headers verbatim was too hard to be worth the trouble.Checked with Fedora 41, which has
clang19.1.5, and with R-devel built withclangandCFLAGS="-O3 -Wall -pedantic -Wp,-D_FORTIFY_SOURCE=3", which reproduced the 0.0.10.4 error withBH1.84.0-0, now checks effectively cleanly, here is the log:00check.log. The 3 NOTES are expected, one for extra CFLAGS, one for time check error (the site they check against is down), and one for new submission after archiving.