feat: add extra equipment installation checks

These checks help spot when something has been installed after it has been removed, or removed before it has been installed
GeoNet · Jul 25, 2024 · 5d3276f · 5d3276f
1 parent 7c4411a
commit 5d3276f
Show file tree

Hide file tree

Showing 9 changed files with 116 additions and 1 deletion.
diff --git a/tests/antennas_test.go b/tests/antennas_test.go
@@ -46,6 +46,19 @@ var antennaChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.InstalledAntennas() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed antenna is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed antenna is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for antenna installation mark overlaps": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 			installs := make(map[string]meta.InstalledAntennaList)

diff --git a/tests/cameras_test.go b/tests/cameras_test.go
@@ -46,6 +46,19 @@ var cameraChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.InstalledCameras() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed camera is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed camera is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for cameras installation mount overlaps": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 			keys := make(map[string]interface{})

diff --git a/tests/dataloggers_test.go b/tests/dataloggers_test.go
@@ -90,6 +90,19 @@ var dataloggerChecks = map[string]func(*meta.Set) func(t *testing.T){
 			}
 		}
 	},
+
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.DeployedDataloggers() {
+				if i.End.Before(i.Start) {
+					t.Errorf("deployed datalogger is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("deployed datalogger is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
 }
 
 func TestDataloggers(t *testing.T) {

diff --git a/tests/doases_test.go b/tests/doases_test.go
@@ -46,6 +46,19 @@ var doasChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.Doases() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed doas is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed doas is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for doases installation mount overlaps": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 			keys := make(map[string]interface{})

diff --git a/tests/metsensors_test.go b/tests/metsensors_test.go
@@ -44,6 +44,18 @@ var metSensorChecks = map[string]func(*meta.Set) func(t *testing.T){
 			}
 		}
 	},
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.InstalledMetSensors() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed metsensor is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed metsensor is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
 	"check for missing metsensor marks": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 			keys := make(map[string]interface{})

diff --git a/tests/radomes_test.go b/tests/radomes_test.go
@@ -34,7 +34,6 @@ var installedRadomeChecks = map[string]func(*meta.Set) func(t *testing.T){
 			}
 		}
 	},
-
 	"check for overlapping radomes installations": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 			installs := make(map[string]meta.InstalledRadomeList)
@@ -63,6 +62,19 @@ var installedRadomeChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.InstalledRadomes() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed radome is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed radome is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for missing radome marks": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 

diff --git a/tests/receivers_test.go b/tests/receivers_test.go
@@ -63,6 +63,19 @@ var deployedReceiverChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.DeployedReceivers() {
+				if i.End.Before(i.Start) {
+					t.Errorf("deployed receiver is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("deployed receiver is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for missing receiver marks": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 

diff --git a/tests/recorders_test.go b/tests/recorders_test.go
@@ -47,6 +47,19 @@ var installedRecorderChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.InstalledRecorders() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed recorder is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed recorder is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for invalid sensor azimuth": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {
 

diff --git a/tests/sensors_test.go b/tests/sensors_test.go
@@ -47,6 +47,19 @@ var installedSensorChecks = map[string]func(*meta.Set) func(t *testing.T){
 		}
 	},
 
+	"check for invalid installation dates": func(set *meta.Set) func(t *testing.T) {
+		return func(t *testing.T) {
+			for _, i := range set.InstalledSensors() {
+				if i.End.Before(i.Start) {
+					t.Errorf("installed sensor is removed before it has been installed: %s", i.String())
+				}
+				if i.Start.After(i.End) {
+					t.Errorf("installed sensor is installed after it has been removed: %s", i.String())
+				}
+			}
+		}
+	},
+
 	"check for invalid sensor azimuth": func(set *meta.Set) func(t *testing.T) {
 		return func(t *testing.T) {