feat: add health checks #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghao
requested changes
Dec 6, 2024
cmd/fdsn-holdings-consumer/main.go
Outdated
| log.Fatalf("error checking queueURL %s: %s", queueURL, err.Error()) | ||
| } | ||
|
|
||
| s3c, err := s3.NewWithMaxRetries(3) |
There was a problem hiding this comment.
Can we remove the pointer at L45, and getting rid of the s3c here? Thanks
cmd/fdsn-holdings-consumer/main.go
Outdated
| ping: | ||
| for { | ||
| err = db.Ping() | ||
| if err != nil { | ||
| log.Println("problem pinging DB sleeping and retrying") | ||
| health.Ok() //send heartbeat |
There was a problem hiding this comment.
Not necessary. If the service stuck during initial DB connection then it's unhealthy
cmd/fdsn-quake-consumer/main.go
Outdated
| ping: | ||
| for { | ||
| err = db.Ping() | ||
| if err != nil { | ||
| log.Println("problem pinging DB sleeping and retrying") | ||
| health.Ok() //send heartbeat |
There was a problem hiding this comment.
Same as fdsn-holdings-consumer
cmd/fdsn-ws/server.go
Outdated
| ctx, cancel := context.WithTimeout(context.Background(), timeout) | ||
| defer cancel() | ||
|
|
||
| msg, err := health.Check(ctx, ":8080/soh", timeout) |
There was a problem hiding this comment.
Can we define ":8080" as a const, then both here and L88 uses that const?
junghao
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://github.com/GeoNet/tickets/issues/13878
Add health check for services