add the ability to set layer thumbnail

[hishamkaram]

setThumbnail Function for geonode-client instead of geoexplorer one

Whart does this PR do?

add setThumbnail Function for geonode-client instead of geoexplorer one.
now in geonode we need to call the new function something like this:

<script type="text/javascript">
        $('#set_thumbnail').click(function () {
            window.setThumbnail(5);
            $('#edit-layer').modal('toggle');
        });
    </script>

Screenshot

Related Issue

#88

[bartvde]

Not sure if you saw the existing work on this: #144

[bartvde]

did you also write a new endpoint (thumbnail/react) or how does this work?

[hishamkaram]

the new end point will handle this post request and create resource thumbnail

[hishamkaram]

@bartvde I will Create pull request to geonode now to add the new endpoint

[bartvde]

@hishamkaram any chance you can refactor your js code so that the core code is in src/services/geonode.js instead like in #144 ?

[hishamkaram]

ok no problem I am going to do that

[hishamkaram]

@bartvde could I create pull request to geonode to add the new endpoint?!

[hishamkaram]

We can use the same old point for react and geoexplorer by sending post paramter to determine the type of layer preview

[bartvde]

let's discuss with @jj0hns0n and @milafrerichs about the geonode endpoint, guys, any input?

[hishamkaram]

@bartvde ok , also now I use the same ENDPOINT

[hishamkaram]

satellite baseLayer Added and layer-switcher postion fixed

[bartvde]

I don't think we should do it this way, this is normally managed on the Django side in geonode for the base maps. Imagine people in a disconnected environment.

[bartvde]

console.log statement

[bartvde]

@hishamkaram let's keep this PR for the thumbnail, and not add other stuff in here, this will make it easier to review and merge. TIA

[hishamkaram]

@bartvde last commit was reverted

[milafrerichs]

can you refresh my memory and explain why we need a new endpoint?

[milafrerichs]

With all the line changes it's hard to determine what is added and what is just a style change.
Can you explain why you changed the style of certain lines?

[bartvde]

sure, in this case we post the image data, in the old case we posted the html of the full map div I believe and printed server-side. It can still be one endpoint if we can distinguish the two modes from the payload

…

Sent from my iPhone

On 30 May 2017, at 17:14, Mila Frerichs ***@***.***> wrote: can you refresh my memory and explain why we need a new endpoint? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[hishamkaram]

No need for the new endpoint . I added a condition to skip generating image in server side if react is the sender because the Image blob would be in the request body. Please review this pull request in geonode here @milafrerichs @bartvde

[hishamkaram]

I.e I use the old ENDPOINT and check if react (geonode client ) is the sender in this point

[kalxas]

@milafrerichs @bartvde is this ok to merge or does it need more changes?

[bartvde]

@hishamkaram can you rebase this on master to see if it fixes the tests? TIA

[hishamkaram]

ok no Problem @bartvde

[hishamkaram]

@bartvde Done

[hishamkaram]

you can find details about changes in geonode here
@bartvde @kalxas @milafrerichs

[bartvde]

thank you @hishamkaram

[kalxas]

thanks @hishamkaram

[hishamkaram]

@bartvde @kalxas you are welcome!