Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api permissions #12706

Conversation

kilichenko-pixida
Copy link
Contributor

Aims to resolve
#12616 and #35

It seems like the problem was that permissions were assigned to None both when handling UI and API document upload. On UI it didn't cause a problem because in UI upload there is also a call setting permissions to defaults again.

github-actions bot and others added 30 commits June 22, 2023 17:36
…with the Django Admin (GeoNode#11189) (GeoNode#11190)

(cherry picked from commit c34e492)

Co-authored-by: mattiagiupponi <[email protected]>
… (GeoNode#11165) (GeoNode#11201)

* FIx download_url for WFS url

* FIx download_url for WFS url

* FIx download_url for WFS url, change settings

* FIx download_url for WFS url, change settings

* Fix tests

* [Fixes GeoNode#11156] Approach change and code rollback

* [Fixes GeoNode#11156] Approach change and code rollback

* [Fixes GeoNode#11156] Approach change and code rollback

* [Fixes GeoNode#11156] Change delete query for original links

---------

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit e103d06)

Co-authored-by: mattiagiupponi <[email protected]>
…eoNode#11214)

* Fix GeoNode#11154 - Wrong login URL in notification

* fix single quote

(cherry picked from commit ad68f2e)

Co-authored-by: Francisco Vicent <[email protected]>
* Bump django from 3.2.19 to 3.2.20

Bumps [django](https://github.com/django/django) from 3.2.19 to 3.2.20.
- [Commits](django/django@3.2.19...3.2.20)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* - Align "setup.cfg" to "requirements.txt"

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessio Fabiani <[email protected]>
(cherry picked from commit de59bce)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…eoNode#11257) (GeoNode#11261)

* Assign regions based on contains and overlaps

* tests

* fix E501
…st fixes [Fixes GeoNode#11264] Fix the italian translation for Position (GeoNode#11284)

(cherry picked from commit 2bdd242)

Co-authored-by: etj <[email protected]>
…#11314)

* expose dataser ows url

* Formatting

(cherry picked from commit 3c5729e)

Co-authored-by: Giovanni Allegri <[email protected]>
…Node#11324) (GeoNode#11325)

* Align the Position labels and translations

* Improvement to it translation

(cherry picked from commit 2b09aa6)

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit 4861375)

Co-authored-by: Giovanni Allegri <[email protected]>
* [Fixes GeoNode#11332] Remove geoip task

* [Fixes GeoNode#11332] Rollback requirements.txt

* [Fixes GeoNode#11332] Rollback setuo.cfg

(cherry picked from commit 95eb82e)

Co-authored-by: mattiagiupponi <[email protected]>
Co-authored-by: Giovanni Allegri <[email protected]>
* Bump client to 4.1.1 and importer to 1.0.4

* Bump version to version 4.1.1
…e#11369) (GeoNode#11370)

* Fix spatial representation type parsing

* improved code

* fixed tests

* fixed formatting

(cherry picked from commit 3fa9a86)

Co-authored-by: Giovanni Allegri <[email protected]>
…dn't be… (GeoNode#11321) (GeoNode#11384)

* [Fixes GeoNode#11320] API V1 delivers information on users that shouldn't be visible

* Fix black and flake8

* Fix black and flake8

* Fix black and flake8

* Fix black and flake8

* [Fixes GeoNode#11320] API V1 delivers information on users that shouldn't be visible

---------

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit c84f55e)

Co-authored-by: mattiagiupponi <[email protected]>
…ode#11485)

* Fixup dataset template

* Fixup document template

* Fixup geoapp and maps template

* [Fixes GeoNode#11430] Fix template typo

(cherry picked from commit 1404400)

Co-authored-by: mattiagiupponi <[email protected]>
Co-authored-by: G. Allegri <[email protected]>
)

* [Backport 4.1.x] SSRF Bypass to return internal host data

* - Test fix

(cherry picked from commit 6503e42)

---------

Co-authored-by: G. Allegri <[email protected]>
(cherry picked from commit 8865884)

Co-authored-by: mattiagiupponi <[email protected]>
…1489) (GeoNode#11490)

* [Fixes GeoNode#11430] Improve metadata template for geoapp

* [Fixes GeoNode#11430] Remove typo

* [Fixes GeoNode#11430] add block for doc

(cherry picked from commit 66ccb3c)

Co-authored-by: mattiagiupponi <[email protected]>
…e#10067) (GeoNode#10072)

* [Fixes GeoNode#10066][Depencendies] Security audit and checks

* -SNYK security fix

Co-authored-by: Alessio Fabiani <[email protected]>
…oNode#10057) (GeoNode#10076)

* -[Fixes GeoNode#10055] Modify Metadata form with permissions check

* - check user in form

* - update tests

* - add tests

Co-authored-by: Giovanni Allegri <[email protected]>

Co-authored-by: NAGGINDA MARTHA <[email protected]>
Co-authored-by: Giovanni Allegri <[email protected]>
ridoo and others added 27 commits June 14, 2024 15:24
As datapackage descriptions can easily take more than 255 characters
it makes sense to relax the contraints here. In this case we just
set no constraints at all.

Fixes GeoNodeUserGroup-DE/geonode-dev-datapackage#23
…eoNode#12392) (GeoNode#12393)

* Fix captcha field visualization in signup page

* fix formatting

(cherry picked from commit d3686f8)

Co-authored-by: Giovanni Allegri <[email protected]>
(cherry picked from commit 7a99ec8)

Co-authored-by: Giovanni Allegri <[email protected]>
…Policy as default (GeoNode#12403) (GeoNode#12404)

* Referre poicy strict-origin-when-cross-origin as default

* adapt proxy tests to adapt to new referrer policy

(cherry picked from commit 8bb5eda)

Co-authored-by: Giovanni Allegri <[email protected]>
Add missing "m" in "Request permission"

(cherry picked from commit dd00006)

Co-authored-by: Sylvain POULAIN <[email protected]>
Some URL needs to be available for download.
Copy link

cla-bot bot commented Nov 6, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @github-actions[bot] on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Copy link

gitguardian bot commented Nov 6, 2024

⚠️ GitGuardian has uncovered 26 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
59204 Triggered Django Secret Key deb7306 .env_local View secret
59204 Triggered Django Secret Key 7a448ec .env.sample View secret
59204 Triggered Django Secret Key deb7306 .env_dev View secret
59204 Triggered Django Secret Key 21373f9 .env.sample View secret
59204 Triggered Django Secret Key deb7306 .devcontainer/.env View secret
9705160 Triggered Username Password deb7306 geonode/base/api/tests.py View secret
863333 Triggered Generic Password 21373f9 .env_local View secret
863333 Triggered Generic Password 7a448ec .env.sample View secret
863333 Triggered Generic Password 21373f9 .env_dev View secret
863333 Triggered Generic Password 21373f9 .env_test View secret
863333 Triggered Generic Password 7a448ec .env_dev View secret
863333 Triggered Generic Password 21373f9 .env.sample View secret
863333 Triggered Generic Password 21373f9 .env_dev View secret
863333 Triggered Generic Password 7a448ec .env_test View secret
863333 Triggered Generic Password 7a448ec .env_local View secret
863333 Triggered Generic Password 21373f9 .env_local View secret
863333 Triggered Generic Password 7a448ec .env_dev View secret
863333 Triggered Generic Password 7a448ec .env_local View secret
9468526 Triggered Generic Password 21373f9 .env_test View secret
9468526 Triggered Generic Password 21373f9 .env_dev View secret
9468526 Triggered Generic Password 7a448ec .env_local View secret
9468526 Triggered Generic Password 21373f9 .env.sample View secret
9468526 Triggered Generic Password 7a448ec .env.sample View secret
9468526 Triggered Generic Password 7a448ec .env_test View secret
9468526 Triggered Generic Password 7a448ec .env_dev View secret
9468526 Triggered Generic Password 21373f9 .env_local View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants