Configure logging #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| } | ||
|
|
||
| private static void processFiles(LK2DxfOptions options) { | ||
| private static boolean processFiles(LK2DxfOptions options) { |
There was a problem hiding this comment.
PP: javadoc that explains boolean return
| } | ||
|
|
||
| EhiLogger.getInstance().addListener(new EhiLogAdapter()); | ||
| EhiLogger.getInstance().removeListener(StdListener.getInstance()); |
There was a problem hiding this comment.
Q: Hat der EhiLogger eine methode um alle listener zu entfernen bevor du unseren hinzufügst?
There was a problem hiding this comment.
Nein, es gibt nur diese beiden add und remove Methoden.
| @@ -332,7 +336,7 @@ private static TransferDescription getTransferDescription(List<LayerMapping> lay | |||
| } | |||
|
|
|||
| try { | |||
| System.out.println("iliModelsPath: " + iliModelsPath); | |||
| LOGGER.info("iliModelsPath: {}", iliModelsPath); | |||
There was a problem hiding this comment.
PP: eventuell auf loglevel debug, da es einfach der pfad ins temp verzeichnis ist, wo die models aus dem jar hinkopiert werden.
There was a problem hiding this comment.
Debug wird aktuell nur mit der --trace Option angezeigt. Das sollte eigentlich reichen, der Pfad wird beim Model-Lookup ja auch wieder angezeigt.
patrickackermann
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15